Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyiQh-0006vv-KM for pgsql-committers@arkaria.postgresql.org; Fri, 25 Nov 2022 23:48:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oyiQg-0000n4-Eh for pgsql-committers@arkaria.postgresql.org; Fri, 25 Nov 2022 23:48:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyiQe-0000m8-Ru for pgsql-committers@lists.postgresql.org; Fri, 25 Nov 2022 23:48:22 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyiQa-0006Ay-Ip for pgsql-committers@lists.postgresql.org; Fri, 25 Nov 2022 23:48:20 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1B13F5C00F4; Fri, 25 Nov 2022 18:48:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 25 Nov 2022 18:48:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1669420095; x=1669506495; bh=kMKNDuc8kM xQMUupm/Ajydnzcwc0TRZ6CP+2T4GXCJE=; b=j4RwHW7CsWAYmsdj1GewUreZiZ ZyBIfGuIp0G+RyqKHCAGITL7pNVrPOeU7/KGUlvCx9yiTg7xoMi0BZ7cQDFwSsSa ntpCG71tuRZvDq38qTBOmgVTLPyUAG12W08ilxHhCkUPty1wEyHQeW8y47OnB1uQ RNZQvXaElsljTW4KcXP7GHfIHL5pD5uB+dHNdeFbUMFvSibyy8H2y/wSGnEy5xV5 bMcoNRL9pI0oUfWYEaM+oD6JE71nw+0vqlXgOSqgwKkdNFybpe2IplW9mH6wtfpo Odk5JEY7z6nnx3PIfI0elXk71MKLuzajnZ+M6swoHpzMdTUB5AQfXquT4Ylw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669420095; x=1669506495; bh=kMKNDuc8kMxQMUupm/Ajydnzcwc0 TRZ6CP+2T4GXCJE=; b=hGZrV1o6vouHao9xp4h+QpOZD15JzvaJczlz9KgVzZ4h 4FeVnr3JRyvr9g6dYgqMoAIqnUQlL/T/Ar4EtIqt3IFR7y6O0p9yO/u/1lF13eof oroNasrCSs2/EZIGHg1b905uaNMOKIQN7wjjMjdQqOKstGP1fNIJ/3iCzKJJGmMs MVdx+76hCnQJXR+ZXxoWi/GESJJL0z7ooCTGm6tNTlfOfEh+/8HzSF0FW3Jxqc53 jpkg6NQZ62Gp7khBnPFoOHNiVEIv81HWQZhvdLzHYTcUDgf5Qlq80FHXT2lU+n1+ nPJayOGXO0RWbmCcOXjJwKsxqGFAEIHTq/ouHR3qjg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieeigdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteevudei tedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 25 Nov 2022 18:48:14 -0500 (EST) Date: Fri, 25 Nov 2022 15:48:13 -0800 From: Andres Freund To: Andrew Dunstan Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Allow building with MSVC and Strawberry perl Message-ID: <20221125234813.25iiq5snxejebdak@awork3.anarazel.de> References: <02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net> <20221125233331.dh4yrd76a3mnwj4s@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221125233331.dh4yrd76a3mnwj4s@awork3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-11-25 15:33:31 -0800, Andres Freund wrote: > FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with > #define __builtin_expect(expr, val) (expr) And it does so with src/tools/msvc as well. I think we might need a preprocessed plperl.c from drongo to analyze this further. There might be some unrelated under-specified build issues, I get weird errors if I start by building plperl.vcxproj, without first having built postgres.vcxproj. But ... Greetings, Andres Freund