Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyixa-00089d-D5 for pgsql-committers@arkaria.postgresql.org; Sat, 26 Nov 2022 00:22:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oyixY-0006SI-O4 for pgsql-committers@arkaria.postgresql.org; Sat, 26 Nov 2022 00:22:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyixY-0006S9-H3 for pgsql-committers@lists.postgresql.org; Sat, 26 Nov 2022 00:22:20 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyixW-0006Rm-DI for pgsql-committers@lists.postgresql.org; Sat, 26 Nov 2022 00:22:19 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 868905C0102; Fri, 25 Nov 2022 19:22:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 25 Nov 2022 19:22:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1669422136; x=1669508536; bh=Bx6wunJxhj XW0sy3kpYOJk3mKjKO8oSG4alEjiDxuDY=; b=kelpimtB8tzV9XAB169ShsunVk yiKD4p7njduW7IraxRNJXlf0B5R/+lmeVEfKsJKOLvYfZH/bZQ0GkEsz5brzP/dM MSBPds7uvHuHqLlibA2Bvk9GqhL5p26JZQNxMN848Xhzd/ZNTyNsNcprNFOfzT6I /qmEHb+Y5lUBMy91on4VqFZgDeNw5yY/L9lEHRxs3NS5tsjoicJmKT1b1p+crmYB 7AOViXWIXm7woeJVqZxMkCWk4b9JzLcr1il8zdxMi/rUSin9r3/R1UfhB5TDe412 ZztrfBpS+wyAeDmD6XlgkUi2aevL4Yre/rSPPu3pSAz1JsvYeRFy1IfxX1kQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669422136; x=1669508536; bh=Bx6wunJxhjXW0sy3kpYOJk3mKjKO 8oSG4alEjiDxuDY=; b=aGTLl9aFERnaQUno/bX0kU0AJPUpX2aIbRDZ34+dUVqt A3NPHYbFUFadE0GAvVt6zhOEM5L5WZn8cB9q4Fbb1ikS77Dy+OwoWg2n3nTI+DYr CIC1V07GfZrjaGU2aQSGvUK/f9iHk3H+vIcWoWpAv5nf86hBwVUZKuUySU7SbbIK nKvdhW0hBemB9oK2Bmtho51kmDUi2UA1Z14/PiTteV5uUByl6Nv51U0XOmnKRi7H xpdU9j6f+4HGpaUSYsGcyis2BJsTgKnsiPqJvQUqWYsmnvjW1i94N8cb+ADJ9J7x TgNvAZ+pYUIuoJBANX0J5YfdWr/21qPNbiwX5kouHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieeigddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteevudei tedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 25 Nov 2022 19:22:16 -0500 (EST) Date: Fri, 25 Nov 2022 16:22:15 -0800 From: Andres Freund To: Andrew Dunstan Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Allow building with MSVC and Strawberry perl Message-ID: <20221126002215.7xcmiza3jexpkemw@awork3.anarazel.de> References: <02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net> <20221125233331.dh4yrd76a3mnwj4s@awork3.anarazel.de> <20221125234813.25iiq5snxejebdak@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-11-25 18:56:02 -0500, Andrew Dunstan wrote: > On 2022-11-25 Fr 18:48, Andres Freund wrote: > > On 2022-11-25 15:33:31 -0800, Andres Freund wrote: > >> FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with > >> #define __builtin_expect(expr, val) (expr) > > And it does so with src/tools/msvc as well. I think we might need a > > preprocessed plperl.c from drongo to analyze this further. > > > > There might be some unrelated under-specified build issues, I get weird errors > > if I start by building plperl.vcxproj, without first having built > > postgres.vcxproj. But ... > > > > > Yeah, drongo builds fine too. Oh - I just looked at HEAD, where it fails in the 'make' stage on the BF. But I now see the PLCheck-C failures in the older branches. > It's the handshake thing that's the current issue. I'll see if forcing > -DNO_THREAD_SAFE_LOCALE works. With it tests do pass for me with meson + msvc + perl 5.32. Greetings, Andres Freund