Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7JIU-00006P-3E for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Dec 2022 16:47:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p7JIS-0003Oq-VK for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Dec 2022 16:47:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7JIR-0003OS-1l for pgsql-hackers@lists.postgresql.org; Mon, 19 Dec 2022 16:47:24 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7JIN-0000wd-Tu for pgsql-hackers@lists.postgresql.org; Mon, 19 Dec 2022 16:47:21 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 9FD285C0182; Mon, 19 Dec 2022 11:47:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 19 Dec 2022 11:47:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1671468436; x=1671554836; bh=b Y9yp8IBoWOjAAOUz0gsJUM1qkjf71XjZikwHjamcIY=; b=lpGnpR4Za6NUfWi9N szeKus0zEk53CoKnMvT91e/yCPkeEyYXMfz1bN2htSNj+l1raIeG5LBaUJDwmCsu 5z+B8Hmkkt18cY6ZEzvpPIPDNouxaFPhWszxoWoMTXi5sPoggg0XGZlG8GjLO/dc iEswgHIvktZxf3Ktl6fjrKmmY7k5qobaiF6luN09twxwq3EEX0pRre/SVEEDpndz n8gUdcYXqrKRFMuPqD8cHJwEjAP2RQHOHb/oy0vuuQ1EcbArLyjnNpGJVh+qJXFB wtivvAWmrSfJohjWd89CHkJUsPZnXabkVLwRaO41FUxxRjMzAjpZ05tOPwd8hg+p ru2Tg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggugfgjsehmkeerredttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeehfeekteegueekveejhfehteetgfevfedvgeekvdevuddv vdetteelgfeffeeifeenucffohhmrghinhepphhoshhtghhrvghsqhhlrdhorhhgpdgvnh htvghrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Dec 2022 11:47:15 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id EEFBFE98; Mon, 19 Dec 2022 17:47:13 +0100 (CET) Date: Mon, 19 Dec 2022 17:47:13 +0100 From: Alvaro Herrera To: Peter Smith Cc: Amit Kapila , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Doc: Explain about Column List feature. Message-ID: <20221219164713.ccnlvtkyj6lmshqq@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="auwwwptwfs2pqkb5" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220915161142.6gtmmezq47nz37oi@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --auwwwptwfs2pqkb5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On 2022-Sep-15, Alvaro Herrera wrote: > On 2022-Sep-15, Alvaro Herrera wrote: > > > Looking at the rendered docs again, I notice that section "31.4.5. > > Combining Multiple Column Lists" is *only* the red-tinted Warning block. > > That seems quite odd. I am tempted to remove the sect2 heading for that > > one too. > > Pushed. I didn't modify this part; I spent too much time looking at it > trying to figure out how to do it. I think this bit really belongs in > the CREATE/ALTER docs rather than this chapter. But in order to support > having a separate for the restriction on combination, we need a > separate for the column_name parameter. So I'm going to > edit that one and I'll throw this change in. I figured out how to fix this one -- just remove the tags, and add a tag to the <warning> box. The attached yields the explanatory text in a separate box that doesn't have the silly otherwise-empty section title. We add the 'id' that was in the sect2 to the warning; with this, at the referencing end the full title is rendered, which looks quite reasonable. I have attached screenshots of both sides of this. Compare the existing https://www.postgresql.org/docs/15/logical-replication-col-lists.html#LOGICAL-REPLICATION-COL-LIST-COMBINING Unless there are objections, I'll get this pushed to 15 and master. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ --auwwwptwfs2pqkb5 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Rework-warning-about-column-list-combining.patch"