Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pD8hZ-0003RR-VQ for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Jan 2023 18:41:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pD8hW-0003DT-Uu for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Jan 2023 18:41:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pD8hV-0003DK-OK for pgsql-hackers@lists.postgresql.org; Wed, 04 Jan 2023 18:41:22 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pD8hS-0005WP-BJ for pgsql-hackers@postgresql.org; Wed, 04 Jan 2023 18:41:21 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B69B55C00BE; Wed, 4 Jan 2023 13:41:12 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 04 Jan 2023 13:41:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1672857672; x=1672944072; bh=e6rXX78qmS qllPJW8ZvuihqvHf04sPFc08T6cUOYDTc=; b=ytMQO6pPBCIXvc17vP/p5hzb/z ImjaN2g0x9MZaVpIuwVIdCi+tmtB9tLFKaRPfbPlkcVKWe5O9cTsXvtqMu1+sZuo 3kiOJenZvpmhXXeBIfzknIL6R7LoQ4ouUnI6Eq44c1fult4uJHdbhmeMx32grKYh gtw/NucRJL0lcjRVehrs10beWLssw8kdSrogZX4cofV3LIzJ4lghtOsc18eI6e58 AZRl3hQ19KLqdm0h1YgAOCJWDHYjbPDw6RyPTn9A2y9ZsMxfiT10EiAASzd1WNg9 /RNnkyXaFDiRo7SuCnJrCFvirBgEXqYj2dHuXaU7toBbJi1sGoZXmTq9wrcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672857672; x=1672944072; bh=e6rXX78qmSqllPJW8ZvuihqvHf04 sPFc08T6cUOYDTc=; b=xAuMajpjdSxVQjxyEl2/x6Qg7bSAjU5za5RXVqRjbHtX iSlxOo4fvXXOOTtFFtM0hrdX8O5usa4mkNiL8y94jxLpsOMTkQ/JJeKbXydWhmhL AIna/pwhM8k6zH8Geie8C6mUcTCtktTX0XwKd1112at0Czw573rz9+dsQb5z430w l+Dko95t1jsyjYjueagptC0AAmYILFlIxpxzymbaY2h1anMn1yiqvZoziT6or29d TSWYyM14asx0jQ6Wt3FHKNfQu2z6/fCKsM7qEqdd9KMimjTJT813FqCBt71pY5U0 RshA3DLCLowSqOa8/h6dEVId7rvQYEjXaRhCetil2g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeeigdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepvdfffeevhfetveffgeeiteefhfdtvdffjeevhfeuteegleduheetvedu ieettddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Jan 2023 13:41:12 -0500 (EST) Date: Wed, 4 Jan 2023 10:41:10 -0800 From: Andres Freund To: Peter Geoghegan Cc: Robert Haas , pgsql-hackers@postgresql.org Subject: Re: pgsql: Delay commit status checks until freezing executes. Message-ID: <20230104184110.nrcfrkwrenihb5ne@awork3.anarazel.de> References: <20230104035636.hy5djyr2as4gbc4q@awork3.anarazel.de> <20230104063325.32xq2gpnwlelhogo@awork3.anarazel.de> <20230104064740.6mnwcml6oqp3sxnr@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-01-04 09:59:37 -0800, Peter Geoghegan wrote: > On Wed, Jan 4, 2023 at 7:03 AM Robert Haas wrote: > > and which functions return fully reliable results, I do > > not think you should be committing your own patches in this area. > > My mistake here had nothing to do with my own goals. I was trying to > be diligent by hardening an existing check in passing, and it > backfired. When moving code around I strongly suggest to make as much of a diff to be "move only". I find git diff --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space quite helpful for that. Being able to see just the "really changed" lines makes it a lot easier to see the crucial parts of a change. > > There is probably a lot of potential benefit in improving the way this > > stuff works, but there is also a heck of a lot of danger of creating > > subtle data corrupting bugs that could easily take years to find. > > It's currently possible for VACUUM to set the all-frozen bit while > unsetting the all-visible bit, due to a race condition [1]. This is > your long standing bug. So apparently nobody is qualified to commit > patches in this area. That's a non-sequitur. Bugs are a fact of programming. > About a year ago, there was a massive argument over some earlier work > in the same general area, by me. Being the subject of a pile-on on > this mailing list is something that I find deeply upsetting and > demoralizing. I just cannot take much more of it. At the same time, > I've made quite an investment in the pending patches, and think that > it's something that I have to see through. I'm, genuinely!, sorry that you feel piled on. That wasn't, and isn't, my goal. I think the area of code desperately needs work. I complained because I didn't like the process and was afraid of the consequences and the perceived need on my part to do post-commit reviews. Greetings, Andres Freund