Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEMJv-0005rx-TU for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Jan 2023 03:26:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pEMJs-0000qn-EL for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Jan 2023 03:26:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEMJs-0000qe-5A for pgsql-hackers@lists.postgresql.org; Sun, 08 Jan 2023 03:26:00 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEMJk-0008OU-Qy for pgsql-hackers@postgresql.org; Sun, 08 Jan 2023 03:25:59 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C82FD5C008F; Sat, 7 Jan 2023 22:25:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 07 Jan 2023 22:25:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1673148351; x=1673234751; bh=iyYuk2BV4A 9l5OIMz1abYAt8C/UAAesLbnktLWQ1GNk=; b=vp3Q6Ld207nOLGiuZcRslBWkt3 pSYFYKrHK3+Zcq8EsdhyQuKG5Lb+vFSRoUu5sJrfOns1hLqQwYBgiP7XIHOtdzuR 6tddh6YiFacW/XswDQ2e5XGNwnATTNUbSubhBQjAdYmPhkVV55sFNhiNoyoAFjRv kDGfs/B5M+vpKYkCixee4NhyvW5vG4lpEUtUec09tiz6xy9N5w3dQ0/UyxDUmkeu +Z+Zhp4SLLtcVAcCpaf2M3YXxhX6tj66tkH4lt3q74UIZjCrV1+YO8AjG9/4aTLs UKcT6Nv8O7Dm0rBOyZPaLWhd2EUiv+h4GvYaz1DihJ7OB/8WO5dv/bwlHqUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1673148351; x=1673234751; bh=iyYuk2BV4A9l5OIMz1abYAt8C/UA AesLbnktLWQ1GNk=; b=RMLbzB5JDxAM4rg2C1++jMLBs7JXMMi3y8fe1g517DNr jbgUu5/faVMtb+zeAyHEJqnPU3nWfCXoN9j1F0FpfR+bWtQXyE57Ho+W7QrSVaHt z0dUyJM0bQnfop53c+7t8w5jzbJSIViU9HWmkd01ubqMl0uzs2WvK0NINmkJF3sj Ikimerf2D7mY9mrNTLg64i1QYz1nOtkjfB0aU5sJNe/krv3HA6v94JO8C/Ab91mG Szsp3brKsiIqKlQ3vDq4OlQ5+U4pzeB3e1q7myehPU5IrleouWBRHnS4oR+y285L ZkWLLhVUKVkemx1AK3c8qfanLplkfBNg8p9tUnFLlQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrkeefgdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteevudei tedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Jan 2023 22:25:51 -0500 (EST) Date: Sat, 7 Jan 2023 19:25:49 -0800 From: Andres Freund To: Peter Geoghegan Cc: pgsql-hackers@postgresql.org Subject: Re: pgsql: Delay commit status checks until freezing executes. Message-ID: <20230108032549.xumh45fv6dicimmh@awork3.anarazel.de> References: <20230104035636.hy5djyr2as4gbc4q@awork3.anarazel.de> <20230104063325.32xq2gpnwlelhogo@awork3.anarazel.de> <20230104064740.6mnwcml6oqp3sxnr@awork3.anarazel.de> <20230107214756.fyrk735xkeetkkby@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-01-07 15:41:29 -0800, Peter Geoghegan wrote: > Do we need to do anything about this to the "pg_xact and pg_subtrans" > section of the transam README? Probably a good idea, although it doesn't neatly fit right now. > Also, does amcheck's get_xid_status() need a reference to these rules? Don't think so? Whad made you ask? > FWIW, I found an existing comment about this rule in the call to > TransactionIdAbortTree() from RecordTransactionAbort() -- which took > me quite a while to find. So you might have been remembering that > comment before. Possible, my memory is vague enough that it's hard to be sure... Greetings, Andres Freund