Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pK0Qz-0008U3-37 for pgsql-committers@arkaria.postgresql.org; Mon, 23 Jan 2023 17:16:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pK0Qx-0004Ot-6u for pgsql-committers@arkaria.postgresql.org; Mon, 23 Jan 2023 17:16:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pK0Qv-0004Ok-K3 for pgsql-committers@lists.postgresql.org; Mon, 23 Jan 2023 17:16:39 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pK0Qs-0003yK-2r for pgsql-committers@lists.postgresql.org; Mon, 23 Jan 2023 17:16:36 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 5E3E2320083A; Mon, 23 Jan 2023 12:16:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 23 Jan 2023 12:16:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1674494190; x=1674580590; bh=fl2S4r4eCt GkuV9aRp8rHlzPKi4w+7sJSDl4e1cX6e0=; b=gzjOYbesgrPZCtiz9s30on7jW7 FcnkyeJD+qCDGVlygpDYoYr+hQml7ryK89CXwgebv7GE0A49vvETdyErxAnRMpu4 Vh/ofwfh0dBRwvcrNBatwV43dtgHn37L+HBwt2TQQz0DRUJLI/JP6SzT9qaV2yaw U1MQPjEO5J2xnVekd/XatI+QpVA32EXggfd6NkqDsuRJTXO2p9JFWzqRPQgjjjfZ vOJEtXiR7ZMzcCnzjQV1r19DPbj4sbf4cpe1AgPB4wBBBqfufS43h9QldVXaM/8f XC3wnVDC+sleq+ea29pyz0fHIkjDWocCSZqfS3IY2QNR8KXJLD8aS+3TlQfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674494190; x=1674580590; bh=fl2S4r4eCtGkuV9aRp8rHlzPKi4w +7sJSDl4e1cX6e0=; b=bgScUE2Gcn1VJpsT1IAmgLSiiXLVR9uxMdfE0Sf1llsP HKxntsj3U0ioWR3MI3ctGRH0XMpRbIt506DfWbYHEbl6i/gyC9nCZF/2J9CR9C90 0rFu8oPfKNsc0LNUkgP9L5Kg7Hl8kJG8TGnqcXpxfy5bcIn/82Ux9HJ6ZOWE1aI0 NW6pv6ujhRgyjRCuBZXoAhxcWpSnRvVZvGwz4dEgnIBT0lW9gxdTqdoXJtRxrCeF ckwaTohnCBKd0QKALYlrz2ex2jjX+vOlx3eUDua560Yd9YsJKpveLb3xOiDGDGuS E/JmRfVbFoEIK9uVnap/BBbJLJ0Epj6gFcU2UPZ2WA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddukedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepveevieffveejtefggeffgfekueeiueekvdethfehieduheejleetjeek ieettdffnecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghr rgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 Jan 2023 12:16:30 -0500 (EST) Date: Mon, 23 Jan 2023 09:16:28 -0800 From: Andres Freund To: Tom Lane Cc: Michael Paquier , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: instr_time: Represent time as an int64 on all platforms Message-ID: <20230123171628.qhteecrag4pite6v@awork3.anarazel.de> References: <1540079.1674454854@sss.pgh.pa.us> <20230123064647.tzxnmql2xkegc7sw@awork3.anarazel.de> <1543364.1674456919@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1543364.1674456919@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-01-23 01:55:19 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2023-01-23 01:20:54 -0500, Tom Lane wrote: > >> Yeah, there was some discussion about that already: > >> https://www.postgresql.org/message-id/20230121190303.7xjiwdg3gvb62lu3@awork3.anarazel.de > > > I was thinking of starting a starting a separate thread about it - it's > > mostly a plpython issue, the fact that my commit caused the compilation > > failure is somewhat random. > > True. It also seems odd to me that per your analysis, we fixed > the _POSIX_C_SOURCE conflict on 4 Aug 2011 and then broke it again > on 18 Dec 2011, yet nobody has noticed for nigh a dozen years --- > there has to be some other element in there. Well, we didn't *fully* break - all the system library headers included via postgres.h are still included first. It's "just" stuff like , that are included later / indirectly, where we broke it. It's not too hard to believe that changing _POSIX_C_SOURCE won't cause immediately visible problems oustide of a few headers that we already included via c.h. Greetings, Andres Freund