Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKLtK-0005Xh-Ff for pgsql-committers@arkaria.postgresql.org; Tue, 24 Jan 2023 16:11:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pKLtJ-0006ME-1l for pgsql-committers@arkaria.postgresql.org; Tue, 24 Jan 2023 16:11:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKLtH-0006M5-5r for pgsql-committers@lists.postgresql.org; Tue, 24 Jan 2023 16:11:20 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKLtC-0007mt-0R for pgsql-committers@lists.postgresql.org; Tue, 24 Jan 2023 16:11:16 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3941B5C0442; Tue, 24 Jan 2023 11:11:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 24 Jan 2023 11:11:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1674576670; x=1674663070; bh=X52D/W2b4Y /2oZSXpTxKRzHXxs8MlAInfOD0vm4+l4I=; b=vIsSOgf1iwAn4jIazyglunBiy0 JCx3VXIZ0jyXJjnDU/YJJ47i1LjEpd94wCIpsLAos9SX7jBasoKCb2KJ6vk2ApHO ylsYYYWPvj9R8wLJbXzWWp01d9CwTR55qJX8xGpkkvm+Sw3BFyI/GmOUyGAOZpi+ Aisimytq8qnwhLVP1y2q43w+WqMz5CHpV8Sie2v7Le7AcUvxTOnOUSXnfbp/RuZV IYBM28PfEFvdf0eRvohj8yldLgPAY6MailCADfrDWBaxfFFTZyXkL6A7YfjWmn4z it0BiMPI85C7UzHHx+sc5aAFahL0VBtro61E1+FMOAAETnyOuEQts3e5tvMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674576670; x=1674663070; bh=X52D/W2b4Y/2oZSXpTxKRzHXxs8M lAInfOD0vm4+l4I=; b=ZE5v4u1Bh35L07ZH4iuMJetLhVh+FyIuX/bZ5SWQJ596 /RufE1Qva/IizNANM3s24QBVqYOxSW+ABfl2FHQd0FD4ZLoCQA5RiiDF8vDDiN/d N/YMyxp689F7rAkx6KjfN+i3/jSsb9APN5QmV0+uVHDl9vqt1S8Nj6UzGH9E6l9L /s23itONkpPm/JTFkfqKjbzeeN5p7qCQGX3Xi3QtsSVGP2EAPPsfi7lLxKphYceR pdS0S0k9QBhOqyXTzSpcGir+0l0HlbcgONdUMaXO8Hha81ugxTLlhKvjtKUnhXyk uvKP4WoTEczhYFxsJ+09nl0BS2FkrTxQZkAP47vF2Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvtddgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepvdfffeevhfetveffgeeiteefhfdtvdffjeevhfeuteegleduheetvedu ieettddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Jan 2023 11:11:09 -0500 (EST) Date: Tue, 24 Jan 2023 08:11:08 -0800 From: Andres Freund To: Tom Lane Cc: Michael Paquier , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: instr_time: Represent time as an int64 on all platforms Message-ID: <20230124161108.b3bls2mc4kch6nve@awork3.anarazel.de> References: <1540079.1674454854@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1540079.1674454854@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-01-23 01:20:54 -0500, Tom Lane wrote: > I'm inclined to think that we should fix the plpython code to be rigorous > about including everything else we need before including the Python > headers. I tried that, but I think it's hard with the current split of plpython headers. Several of the plpy* headers, most significantly plpy_typeio.h, include "postgres" headers. Which means that .c files can't include plpy_typeio.h and still maintain the ordering of plpython headers coming last. The only way I see that maintains the split of the plpython headers is to institute the rule that plpy_* can't have any includes other than plpython.h, and all their dependencies have to come from plpython.h. I'll go and start a dedicated thread, this is too big a mess to discuss just on -committers. Greetings, Andres Freund