Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKnau-0008KU-9O for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Jan 2023 21:46:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pKnRz-0003I5-5d for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Jan 2023 21:36:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKnRy-0003HZ-Qa for pgsql-hackers@lists.postgresql.org; Wed, 25 Jan 2023 21:36:58 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pKnRw-0008Fr-3A for pgsql-hackers@postgresql.org; Wed, 25 Jan 2023 21:36:58 +0000 Received: by mail-pj1-x1033.google.com with SMTP id lp10so16462120pjb.4 for ; Wed, 25 Jan 2023 13:36:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FTzCK9CH9K/WC9MeG/19Sam0xzgVXaTbiI4O1ZuHUZI=; b=AVCfqFk5yxQKFKtLfgacvBYeLmPhLDR54/HrYe1CSByTM97618+B/qIf4zZiTeQfUJ 0vjym2aCVk9/Nhdye1aEGfnwbMkl6ubNj7hcLisSVGRxJMRlXWT4QgSAhjsMb4r9WkMH EsLrmxZbgRuKyzE8cTlW1g6vaVoIm+2f1yDM0+8BXWQm5xRrScD3wokTrebEjp4LzhYy qO0jYsqTTRJv5hOuNULtJuHIQnwMx3/YhP7SSRaJQ/SdluQnPrlEKBkqPKOUcO7WYbHc 2PZZhHr8rhozRSHmLIrbT8HlhFr/iwD11vmMvH2toAGC04BxXekKQcezkIaOb7IYqDUY ZQgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FTzCK9CH9K/WC9MeG/19Sam0xzgVXaTbiI4O1ZuHUZI=; b=h5FcDiS2GkT7pAcH44yBGSM6+YnN01sw4K9G4meBzAvYjjo86kG0OyRIT52JaXctzy 1fw8xvR19Dl6XbqHuFw4EFGM32MbsI1n4fK7ZFkJUqZimhpBjXWCaWWO3LJSAGY/ZD+U GDAe95fqZYvGW7xTVqwheXU56dFkS2c+H8KfoAxVfmtmAd2A7yuA3mOIBz1Qbsi4ARnx KjZrZgS8FF1Eu17j/f7Kb/M4AwvHHqtYZswtvjUp6m/KOS9vk6+2WDXSlgWuUOs2Revu J8tlW0yO9vIeJe3zdu8EqXLuOb9IU9jcDcia+7uKQiGi/q90sdD25G57PeRfpcTE+GIG Zo4w== X-Gm-Message-State: AFqh2kp2yQ8W5Ka61BN88DOmB3AA6IBzPOpXKQ6hIorWHdwn5gUdFco5 NER7sWNH5+auiqCuCDsFG7o= X-Google-Smtp-Source: AMrXdXu5ynf6+ZHVlCf8H8ONvhbCx15+hpUHzwjewt4fe506LOIxMEaWo0N/J2HrEtvAkjDLoXf5UA== X-Received: by 2002:a05:6a21:33a1:b0:b9:92c2:7ece with SMTP id yy33-20020a056a2133a100b000b992c27ecemr25913631pzb.34.1674682494040; Wed, 25 Jan 2023 13:34:54 -0800 (PST) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id g190-20020a6252c7000000b0057a9b146592sm4078041pfb.186.2023.01.25.13.34.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 13:34:53 -0800 (PST) Date: Wed, 25 Jan 2023 13:34:51 -0800 From: Nathan Bossart To: Robert Haas Cc: Michael Paquier , "pgsql-hackers@postgresql.org" Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module Message-ID: <20230125213451.GA1100929@nathanxps13> References: <20230125181750.GC1098626@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Jan 25, 2023 at 02:05:39PM -0500, Robert Haas wrote: > On Wed, Jan 25, 2023 at 1:17 PM Nathan Bossart wrote: >> I wanted to merge basic_archive and basic_recovery because there's a decent >> chunk of duplicated code. Perhaps that is okay, but I would rather just >> have one test module. AFAICT the biggest reason to split it is because we >> can't determine a good name. Maybe we could leave the name as >> "basic_archive" since it deals with creating and recovering archive files. > > Yeah, maybe. I'm not sure what the best thing to do is, but if I see a > module called basic_archive or basic_restore, I know what it's about, > whereas basic_wal_module seems a lot less specific. It sounds like it > could be generating or streaming it just as easily as it could be > archiving it. It would be nice to have a name that is less prone to > that kind of unclarity. Good point. It seems like the most straightforward approach is just to have separate modules. Unless Michael objects, I'll go that route. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com