Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKoOG-0002zw-Rb for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Jan 2023 22:37:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pKoOF-0001T1-Gm for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Jan 2023 22:37:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKoOF-0001Po-7G for pgsql-hackers@lists.postgresql.org; Wed, 25 Jan 2023 22:37:11 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pKoOC-0000Ya-P3 for pgsql-hackers@postgresql.org; Wed, 25 Jan 2023 22:37:10 +0000 Received: by mail-pg1-x534.google.com with SMTP id 141so24688pgc.0 for ; Wed, 25 Jan 2023 14:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OudFZUrWgPtWEkCjUSC5L8YIDj/rq+dxAM9amYXF9/Q=; b=iAR30H7MYBBZTJvSrCBrHc4PeKthUYpvhzNM8vSzOjSafJEw0KgFovmYlflTAjnIXN IqtHDZBJFEeYm6Q6ikRWZwEm1D2ABYne1bwwLympfG1b/COZCCPn225QI6o13dOb95v5 kYx4oyRfQbPsE7LBAOXjK+pLO5gIfHJlqNG5hJsnRHuxpZXwiBCCyHq9B1EFeGmY83ha TMRicen3NXRdjzcyuX0QD2wxUnN7cwAzs9SEtbCeNzpXvvbcOpJrlMnO1IjCxWaadHQu JEhW6x+jGWOosdx1/MWp2ezkNcMnpzL+IWCxI9QHxK+jKaF7lnqJbFY4LR6rYSI0gyGu oKDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OudFZUrWgPtWEkCjUSC5L8YIDj/rq+dxAM9amYXF9/Q=; b=A0EdDlw0f6vGXLn791gKIXEyRseIPLXa7J3Kmauc5xUNYLwJyYZLIdgRo3dKHiKVlF yHIJ6VZEom72Shun5uFOf3J8t8EkkbpnAuxM5GBXji2Wg2X5bvjw0M6EfjE0VzKUuD5U x2EVXTM3ACO1ZrDa/QuZxHmdmc5iLSR7PpU5uWI9ruHoP4R4S/Xb8vwZOTx/GmmiHHw5 wcWFG755ftyTJf7nh/dVlQJkBot0xs+0/fTQ23SKETA6fwXChYjzo8ArHbO3ihiVoyoY fA7YtNUFQ2+ffEKWlw4QWTSciRjNVrWhd4ugbuJZTweEMMDStghoatqNjhJApzdzJw7j M0Pw== X-Gm-Message-State: AFqh2kqX4L789YhJ2cbdtl0fUP00C0jW5LldUlzcvFOyv7sAmSgxdhWN s8eamBWVguSytZiO+pBOCvc= X-Google-Smtp-Source: AMrXdXuAPkpYQaM7Mb0btB7Ii8xZ4RksadaEVfC8Fsmw7VQi4Q1rI8jHALodcOptbi2zpPi4161tbg== X-Received: by 2002:a62:61c4:0:b0:581:a8dc:8f95 with SMTP id v187-20020a6261c4000000b00581a8dc8f95mr32501728pfb.12.1674686226829; Wed, 25 Jan 2023 14:37:06 -0800 (PST) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id d20-20020aa78694000000b00575fbe1cf2esm4142413pfo.109.2023.01.25.14.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 14:37:06 -0800 (PST) Date: Wed, 25 Jan 2023 14:37:04 -0800 From: Nathan Bossart To: Tom Lane Cc: Robert Haas , Michael Paquier , "pgsql-hackers@postgresql.org" Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module Message-ID: <20230125223704.GA1164580@nathanxps13> References: <20230125181750.GC1098626@nathanxps13> <2848918.1674683422@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2848918.1674683422@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Jan 25, 2023 at 04:50:22PM -0500, Tom Lane wrote: > Nathan Bossart writes: >> I wanted to merge basic_archive and basic_recovery because there's a decent >> chunk of duplicated code. > > Would said code likely be duplicated into non-test uses of this feature? > If so, maybe you ought to factor it out into a common location. I agree > with Robert's point that basic_wal_module is a pretty content-free name. I doubt it. The duplicated parts are things like _PG_init(), the check hook for the GUC, and all the rest of the usual boilerplate stuff for extensions (e.g., Makefile, meson.build). This module is small enough that this probably makes up the majority of the code. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com