Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pL71k-0006Gi-Fs for pgsql-committers@arkaria.postgresql.org; Thu, 26 Jan 2023 18:31:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pL71j-0000Rf-AY for pgsql-committers@arkaria.postgresql.org; Thu, 26 Jan 2023 18:31:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pL71j-0000RV-3V for pgsql-committers@lists.postgresql.org; Thu, 26 Jan 2023 18:31:11 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pL71g-0004k8-PH for pgsql-committers@lists.postgresql.org; Thu, 26 Jan 2023 18:31:09 +0000 Received: by mail-il1-x12b.google.com with SMTP id z2so559010ilq.2 for ; Thu, 26 Jan 2023 10:31:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZiKqUoZKVzxcnNHz5pBgiW7hOkm2JXoBI+Rbb0EaSoE=; b=tPB+O4aGF9/rXkI4UYCe3g22vLdfVwsiHvZE5feF5QXER2dHCr+VC4t3KyUCQCvh/4 /YAXpnCi48VIgyw5OIwaf95ERfcVrsLSv8uErEmIqoer6k36UH5vWPE29S6sx95fBuTs rahRO4SoVIu4s27rZn2rJ0fbLsuabrQ1EfCrETAiyETUwJVxTnnNeOsuios8IGi6BzL5 tJYGN/aaKchOAnESSLyRJVu0D+EfIJ6bgn3sflQdQZKFgsv/MSoDvwX7KgLHXpOgUaVi qUA378P86yaZorZSC/sDb3YEl26ZjJ44oXFLApbZp24TU5nwOhRHbhUuHqSBEGNvPChU VbQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZiKqUoZKVzxcnNHz5pBgiW7hOkm2JXoBI+Rbb0EaSoE=; b=tNkdm+6pB/Xh3nTG13t+2SgBsc0Ik4NBmOAdlHKGBj8r1VHVNJjzI3l4IcN9mTr4Fw k4QBua/k/m6wlJmnLC9qs8HXvxY5lccoVKYsdL/p1LDtYZMdKPX0m3DjqJCDapvJvur4 pKTg8iUnxo3WWB4XfTnELKtCn8aB2LwGvXBsjzEUM2jT8OmcjlRvZ6xLarPCM22yKaIh kJ/EtaeX1uM1wFH8yrAHUSlRK3bEfGcJY5MnY4CkSa6a3PbF0kTyNowqlTwMkXXkCuFe DZcUatRKKDQ7VjSJZeAcvruR5eBj1IeKkCXzJS51gvlg5JhTUe7BxVQckQngP0zF7uce FcYQ== X-Gm-Message-State: AO0yUKWElCGZnLFHiI803cUHuqUM8aJP5SyPNzzuREmVS2oJP1MsuDlO U0VUvBjbcA53AaW0GIXyQ0BWwg== X-Google-Smtp-Source: AK7set9s6HGndx8tiAEGgkQzDG+rFTMv7kd0bqERHOt2c2HeEjwZF+hlduUImuvWaDFPupy/wG4LRw== X-Received: by 2002:a05:6e02:152b:b0:310:9ec2:6e71 with SMTP id i11-20020a056e02152b00b003109ec26e71mr7446517ilu.32.1674757867975; Thu, 26 Jan 2023 10:31:07 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id q17-20020a02cf11000000b003a36ce2cd5asm666757jar.160.2023.01.26.10.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 10:31:07 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 81B3C800CA9; Thu, 26 Jan 2023 12:31:06 -0600 (CST) Date: Thu, 26 Jan 2023 12:31:06 -0600 From: Justin Pryzby To: Andrew Dunstan Cc: Robert Haas , Alvaro Herrera , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties. Message-ID: <20230126183106.GS22427@telsasoft.com> References: <20230126114659.x3yuypot7p6zj73c@alvherre.pgsql> <25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Jan 26, 2023 at 09:46:07AM -0500, Andrew Dunstan wrote: > > On 2023-01-26 Th 08:00, Robert Haas wrote: > > On Thu, Jan 26, 2023 at 6:58 AM Alvaro Herrera wrote: > >> On 2023-Jan-24, Robert Haas wrote: > >> > >>> Adjust interaction of CREATEROLE with role properties. > >> This commit broke the ability to run 'make installcheck' repeatedly, > >> because it fails to drop role regress_role_limited_admin. > > Argh, sorry. I keep making that mistake. > > > Would it be worth adding a check right at the end of the schedule that > makes sure there are no such roles left? Yes, because the alternative is to have cirrus run "installcheck" twice..