Date: Tue, 31 Jan 2023 11:28:06 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
	Michael Paquier <michael@paquier.xyz>,
	pgsql-hackers@lists.postgresql.org,
	Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: pg_upgrade test failure
Message-ID: <20230131172806.GM22427@telsasoft.com>
References: 
 <CA+hUKG+bk4KGwYT4JrZEdAgNdFm-c8ezTrxf-PacS-npQ_HdSw@mail.gmail.com>
 <YzqBIzMwoBiESmkk@paquier.xyz>
 <CA+hUKGKsdzw06c5nnb=KYG9GmvyykoVpJA_VR3k0r7cZOKcx6Q@mail.gmail.com>
 <Y04mN0ZLNzJywrad@paquier.xyz>
 <20221018043144.GF7745@telsasoft.com>
 <20221018162908.cb3n7tahtekypbkf@awork3.anarazel.de>
 <CA+hUKGKFh-F2fz_18j3N6bKr966gmaJxV40T0qhDwhKkW+291g@mail.gmail.com>
 <20221206181533.pmcz75zbjgvnnzum@awork3.anarazel.de>
 <CA+hUKGJTM5FswRV-_JWzVLdw=Lq1pjNsvGfONRJp=dpR6YR81Q@mail.gmail.com>
 <CA+hUKGLfruDhC_8QRGDoCndsdzDVjrf7TYwgsv+OfoAmK2syEg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+hUKGLfruDhC_8QRGDoCndsdzDVjrf7TYwgsv+OfoAmK2syEg@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20230131172806.GM22427%40telsasoft.com>
Precedence: bulk

On Tue, Jan 31, 2023 at 02:00:05PM +1300, Thomas Munro wrote:
> On Thu, Jan 5, 2023 at 4:11 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> > On Wed, Dec 7, 2022 at 7:15 AM Andres Freund <andres@anarazel.de> wrote:
> > > On 2022-11-08 01:16:09 +1300, Thomas Munro wrote:
> > > > So [1] on its own didn't fix this.  My next guess is that the attached
> > > > might help.
> >
> > > What is our plan here? This afaict is the most common "false positive" for
> > > cfbot in the last weeks.
> 
> I pushed the rmtree() change.  Let's see if that helps, or tells us
> something new.

I found a few failures since then:

https://api.cirrus-ci.com/v1/artifact/task/6696942420361216/testrun/build/testrun/pg_upgrade/002_pg_upgrade/log/regress_log_002_pg_upgrade

pg_upgrade: warning: could not remove directory "C:/cirrus/build/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20230131T134931.720/log": Directory not empty
pg_upgrade: warning: could not remove directory "C:/cirrus/build/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20230131T134931.720": Directory not empty

https://api.cirrus-ci.com/v1/artifact/task/5119776607961088/testrun/build/testrun/pg_upgrade/002_pg_upgrade/log/regress_log_002_pg_upgrade
same

I verified that those both include your 54e72b66e, which is pretty
strange, since the patch passed tests 10s of times on CI until it was
merged, when it started/kept failing.

-- 
Justin