Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg8Vj-00085F-CE for pgsql-committers@arkaria.postgresql.org; Sat, 25 Mar 2023 18:21:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pg8Vi-0004tS-1e for pgsql-committers@arkaria.postgresql.org; Sat, 25 Mar 2023 18:21:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg8Vh-0004tJ-Qe for pgsql-committers@lists.postgresql.org; Sat, 25 Mar 2023 18:21:01 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg8Vf-0004jY-DV for pgsql-committers@lists.postgresql.org; Sat, 25 Mar 2023 18:21:01 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 72EA132001C6; Sat, 25 Mar 2023 14:20:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 25 Mar 2023 14:20:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1679768457; x=1679854857; bh=2G 9zSEqYcQuKzIFov3R99bwVCF6YpKYxGl40Nytk+Ak=; b=f4npQHM9zqRD6eELft jK4wjKs32FCiwJFfhH6yXSIDP7mnzgIZM/Y1Ve5TMlQJf/4LZhKWQMxzPMwZJaOE 7GH4NfmdTC3aFj0k3kLENNQn7SCdNL/z88gNqOXn2ZH92Q+HDJi1rEu7yOF6DVYM d57+Qkiu1txSq1JqPzuYkGScVxiYcjablU7Gg9VftOmFG9N68gNhQZRhMKYvWVOX TV6KBJagSlky66SpZmHkS/2sOW4X1L816O8DFJtBpskhqClWMeeNS825a64Vwndt zVmUOr1kOYT0nmEH+7v1IiB1t6K01IwFHpwFMV3ooHl0eUV1yJtOfp8pBe12fJ73 qEbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679768457; x=1679854857; bh=2G9zSEqYcQuKz IFov3R99bwVCF6YpKYxGl40Nytk+Ak=; b=FV+mwjBXuRBZa1MDQUIqgnBl5Q4Iv q7/YSCIq0qAJYh4TP7eMbgqro9bgx7jP2FjgrgRK1i7eX3lWmExWTS5T3AbD0577 NrZc0d7oWWYukhtz3lQQ3w3SmMBI4f+2qGriP5EjsdXIGuG1l/aMSqFm9A9zeExy 4hquvPxVl0VTBpDPmJzpwsELCpCvwj5UlLVwrlbfdc9nYEg2XA3gbOjOsqhbTm2R 9YpV3a222I4EH/f61f/2BimO1l3RqynHmTFIlCqO0u+poNIJvSu9M3VdZEiUd2cF FOYOdYrBgbDLoeZIve22HN0blpvzBsNlI34uFjwtsSDXgobVQibR/JoZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegkedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteev udeitedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Mar 2023 14:20:56 -0400 (EDT) Date: Sat, 25 Mar 2023 11:20:55 -0700 From: Andres Freund To: Justin Pryzby Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: meson: add install-{quiet, world} targets Message-ID: <20230325182055.7e5tekype2ofn3kx@awork3.anarazel.de> References: <20230325180310.o6drykb3uz4u4x4r@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-03-25 13:05:19 -0500, Justin Pryzby wrote: > On Sat, Mar 25, 2023 at 11:03:10AM -0700, Andres Freund wrote: > > Hi, > > > > On 2023-03-25 12:51:32 -0500, Justin Pryzby wrote: > > > On Fri, Mar 24, 2023 at 04:30:52AM +0000, Andres Freund wrote: > > > > meson: add install-{quiet, world} targets > > > > > > if docs.length() == 0 > > > run_target('docs', command: [missing, 'xsltproc']) > > > else > > > alias_target('docs', docs) > > > + alias_target('install-docs', installdocs) > > > endif > > > > > > This fails to handle installdocs.length() == 0 > > > > You mean in the sense of causing a failure in meson, or not providing the > > install-docs target? For the latter: Yea. I wasn't sure what the behaviour > > The former, I guess. I was going to look into the windows python header > warnings, but the configure step failed like: > > [17:27:16.781] doc\src\sgml\meson.build:327:2: ERROR: alias_target takes at least 2 arguments, but got 1. Huh - I thought that wouldn't be possible, because docs would also be empty in that case. But it's not, because I added postgres-full.xml to docs (probably so you can see docs xml validity issues with just xmllint available). So "your" error happens if just xmllint, but not xsltproc is available. I think the easiest "fix" might be to just define install-docs to also include docs - that way install-docs at least checks the validity of xml, even if we can't build any docs. Greetings, Andres Freund