Feedback-ID: id4a34324:Fastmail
Date: Wed, 5 Apr 2023 16:58:41 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't initialize page in {vm,fsm}_extend(), not needed
Message-ID: <20230405235841.6lqaxjkndh2qlmii@awork3.anarazel.de>
References: <E1pk5tJ-001W2q-Bq@gemulon.postgresql.org>
 <2194723.1680736788@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2194723.1680736788@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20230405235841.6lqaxjkndh2qlmii%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-04-05 19:19:48 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Don't initialize page in {vm,fsm}_extend(), not needed
> 
> Various buildfarm members are complaining about under-braced
> initializations added by this commit.
> 
> visibilitymap.c: In function \342\200\230vm_extend\342\200\231:
> visibilitymap.c:625:2: warning: missing braces around initializer [-Wmissing-braces]
>   PGAlignedBlock pg = {0};
>   ^
> visibilitymap.c:625:2: warning: (near initialization for \342\200\230pg.data\342\200\231) [-Wmissing-braces]
> 
> freespace.c: In function \342\200\230fsm_extend\342\200\231:
> freespace.c:611:2: warning: missing braces around initializer [-Wmissing-braces]
>   PGAlignedBlock pg = {0};
>   ^
> freespace.c:611:2: warning: (near initialization for \342\200\230pg.data\342\200\231) [-Wmissing-braces]
> 
> This is from buri, similar from curculio, dragonet, idiacanthus,
> xenodermus, etc

I really don't see the point of placating old compilers for things like
this. It's just inflicting pain on ourselves without any reward. Just to be
clear: I didn't knowingly trigger the warning.

Either way, an upcoming commit will implement vm_extend() / fsm_extend() with
generic code, then the warning will be gone.

Greetings,

Andres Freund