Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkXJG-0001mP-IY for pgsql-committers@arkaria.postgresql.org; Thu, 06 Apr 2023 21:38:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pkXJF-0008U5-Es for pgsql-committers@arkaria.postgresql.org; Thu, 06 Apr 2023 21:38:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkXJD-0008Tv-UK for pgsql-committers@lists.postgresql.org; Thu, 06 Apr 2023 21:38:21 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkXJA-0005C9-LR for pgsql-committers@lists.postgresql.org; Thu, 06 Apr 2023 21:38:18 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CA5005C00E8; Thu, 6 Apr 2023 17:38:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 06 Apr 2023 17:38:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680817094; x=1680903494; bh=xG xe5OmO9bZ1E5mycqK6hkSy1ray0q1TBqY4u4FaJgw=; b=SkTMygX/npmq496bUF CVElTjyYtxW2L5QPRto0LzDJ8xs4ta6DcVWTeFHe8wqL4PM6ZATzq0Qa3Mg5B38y gpB2qJlxVnx3OaMTxvbHiTLamXftxEPvH78AbfdriKyZZYh/1+mRKgtZ/DXq94Sc 9dw9or1ULo8kX2x85s9dS0Fpxkzlh9igea0T6KZNKMMfB1I204q7CKtL02hQaAwb OEU3KFTvWlqCnI/zXUmJ3ggWDlSlqMvLwX3N/Eq1h7H18u9iX/6PufxzFs4g2j66 8aW/afxojXlUHe5I9TKY0Q4wmOn3YmRRlCpQ+CxplqgOd5j+/Ca/eTPFZ4wG6CZo b1Ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680817094; x=1680903494; bh=xGxe5OmO9bZ1E 5mycqK6hkSy1ray0q1TBqY4u4FaJgw=; b=dcYmpRSKxF6ksQ4am94XYlebRw9f8 N3IyI8oM9LNO1iIXO4e+QIXeUpkoDwThFgi1qDbt81ttr+PqQc2V+01wRDfOGMap /emGd3HNF3kydoVS1cliHpArW31W8E2y1nuiSQkSGS6+D/XbTJIgI5l/JlqdSh/Z rBbOBwfApxBIrNtDoA27X6nahrMxn7dWfOPNc4dSZvq7bpUGEIcQbNTn+XWu4OHt TWZTaAvGoJs1YLZIhcuhNMYOLT01lJzSJfYaVI9An2XeiB8ccuN/ct/ZJLoVx70T pecs2zUUhvwSObg+ijATky1rX+u1eIg6SuiNJ6MRo/Vk7xZoSgMVzpEVQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejfedgudeivdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesth dtredttddtvdenucfhrhhomheptehnughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshes rghnrghrrgiivghlrdguvgeqnecuggftrfgrthhtvghrnhephfegjedtudegveffteefje eljedvgeetueelffdtffejgeffgeeggeffteegheeunecuffhomhgrihhnpegtihhrrhhu shdqtghirdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Apr 2023 17:38:14 -0400 (EDT) Date: Thu, 6 Apr 2023 14:38:13 -0700 From: Andres Freund To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te Message-ID: <20230406213813.uep7plg6lvcywujo@awork3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-04-06 19:52:55 +0000, Tom Lane wrote: > Fix ts_headline() edge cases for empty query and empty search text. Unfortunately there appears to be some portability issue with this. Causes a test output difference on macos. Noticed it when testing something I was about to push, and I was very confused for a second how my change could have a portability aspect :) https://cirrus-ci.com/build/6629557554380800 https://api.cirrus-ci.com/v1/artifact/task/4764833480966144/testrun/build/testrun/regress/regress/regression.diffs diff -U3 /Users/admin/pgsql/src/test/regress/expected/tsearch.out /Users/admin/pgsql/build/testrun/regress/regress/results/tsearch.out --- /Users/admin/pgsql/src/test/regress/expected/tsearch.out 2023-04-06 20:03:11 +++ /Users/admin/pgsql/build/testrun/regress/regress/results/tsearch.out 2023-04-06 20:05:56 @@ -2133,6 +2133,9 @@ NOTICE: text-search query doesn't contain lexemes: "" LINE 2: '', ''::tsquery); ^ +NOTICE: text-search query doesn't contain lexemes: "" +LINE 2: '', ''::tsquery); + ^ ts_headline ------------- Sure looks like somehow there's duplicate NOTICEs? Greetings, Andres Freund