Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm4HS-000351-Qj for pgsql-committers@arkaria.postgresql.org; Tue, 11 Apr 2023 03:02:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pm4HR-00077j-3i for pgsql-committers@arkaria.postgresql.org; Tue, 11 Apr 2023 03:02:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm4HQ-00077a-Qc for pgsql-committers@lists.postgresql.org; Tue, 11 Apr 2023 03:02:48 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pm4HJ-0006jZ-S1 for pgsql-committers@lists.postgresql.org; Tue, 11 Apr 2023 03:02:47 +0000 Received: by mail-pj1-x102d.google.com with SMTP id d22-20020a17090a111600b0023d1b009f52so9506497pja.2 for ; Mon, 10 Apr 2023 20:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681182161; x=1683774161; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=JLc5QgJgxYfsHIpSR6eHVv7tpltBp4NVGCdXwx+ghdg=; b=knruHD6hUse2ZbuD0hYrAC9oarPfCHRqR+14NipXrSmVT6kQOdDgSY8B+kzvxzRQ8K GVMewic5E979dyvQqt1oUgDMwdXx62uC+4Y0osuZwwcfmP+8CLDhzgtMYDl+EO15duqU +4+NPg6U4Er25h2cF8gM/WLZWUjt2tMHMUFkk4/XWR9FKE5r5aI4AilxP9MI/j5wHgvC +js6g16KugxLOOh1sNxjMw5E5qJWUYZtkBormh6+LADca58ndxpaR0JS2obKs3M38Cgf oZ+xYXdmGgEyYOIZzNYd0REtjMUR8TXvvx4gf85U/+165a6csb8biKLJsjbRECe3B3E6 Umuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681182161; x=1683774161; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JLc5QgJgxYfsHIpSR6eHVv7tpltBp4NVGCdXwx+ghdg=; b=m3A7nFtM854pfly3Gyhh1/7TmhJAp9gRZ9aNL7/N147zcQGri6XWC+5XL/iAxFoi5M biyquMjItgtle8JVHmmhCOft0Q/La55yiiChjGG57bek1pCWQN2gQtCVSXaSzTj1yRrO N7v69e6S4IGgN6cEB3Bmk/ueesLd/nkHPoDkbSZfjnm7M1heflrrMDXlTK8IA/gtEh10 LGrhu4MYknRf8NMXTJmtiaj+liirYVBO1M5Wbolm+qKYLzRNcETr2nL6+Xc6wm6YFaN+ aU8STDv0PA+WezNop+kReOMAglZafGK2PszURCTs75L0oOZUnEVasQDke8CJQ+ezjgP3 veVg== X-Gm-Message-State: AAQBX9cnNBUQexNkVgGTtaUyPLsyI77SCNZ2b8edLp+5SgwFKcCMqscG aAbKC/ocsp6b8/xqK86mpkI= X-Google-Smtp-Source: AKy350YGBTmkXWOVqe6pgakfjWIjo28s99Xfdv04TD+76CcPYlzVaZK/7WEzVxqRlDiFoQbh7unn4Q== X-Received: by 2002:a05:6a20:121f:b0:e8:825a:7af5 with SMTP id v31-20020a056a20121f00b000e8825a7af5mr8596762pzf.14.1681182160597; Mon, 10 Apr 2023 20:02:40 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id p19-20020a634f53000000b0050be8e0b94csm7535456pgl.90.2023.04.10.20.02.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Apr 2023 20:02:40 -0700 (PDT) Date: Tue, 11 Apr 2023 12:02:38 +0900 (JST) Message-Id: <20230411.120238.1102085277698061857.horikyota.ntt@gmail.com> To: drowley@postgresql.org Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option From: Kyotaro Horiguchi In-Reply-To: <20230411.102335.1643720544536884844.horikyota.ntt@gmail.com> References: <20230411.102335.1643720544536884844.horikyota.ntt@gmail.com> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I apologize for writing mails in such a sporadic manner.. At Tue, 11 Apr 2023 10:23:35 +0900 (JST), Kyotaro Horiguchi wrote in > Hello. > > > Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option > > This commit added the following error message. > > > errmsg("value: \"%s\": is invalid for buffer_usage_limit", > > It looks as the follows on terminal. > > postgres=# vacuum (buffer_usage_limit 'x'); > ERROR: value: "x": is invalid for buffer_usage_limit > > I'm not sure why the message has two colons. [1] talks about the > message but doesn't really explain the reason for this. > > [1] https://www.postgresql.org/message-id/CAApHDvqs%2BFcw9Yrn4ORCAX0xKK1-SiCC0w1j7Dhg%3DG9hrvag7g%40mail.gmail.com vacuum.c:198 > if (opt->arg == NULL) > { > ereport(ERROR, > (errcode(ERRCODE_SYNTAX_ERROR), > errmsg("buffer_usage_limit option requires a valid value"), > parser_errposition(pstate, opt->location))); > postgres=# vacuum (buffer_usage_limit); > ERROR: buffer_usage_limit requires a valid value The error message doesn't really make much sense to me. In the same context, most of the code seems to use ("%s requires a parameter", buffer_usage_limit) without "valid". vacuum.c:347 > errmsg("BUFFER_USAGE_LIMIT cannot be specified for VACUUM FULL"))); It seems like that the vacuum options are usually spelled in uppercase at least for vacuum and analyze. In any case, shouldn't we need to unify them in a certain area? (For example, command options for CREATE SUBSCRIPTION is shown in lowercase in the documentation. But, I'm not exactly sure what we should do about it.) regards. -- Kyotaro Horiguchi NTT Open Source Software Center