Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm4Hk-00036B-4a for pgsql-committers@arkaria.postgresql.org; Tue, 11 Apr 2023 03:03:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pm4Hj-000888-2e for pgsql-committers@arkaria.postgresql.org; Tue, 11 Apr 2023 03:03:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm4Hi-00087z-S6 for pgsql-committers@lists.postgresql.org; Tue, 11 Apr 2023 03:03:06 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pm4Hg-0029CS-GM for pgsql-committers@lists.postgresql.org; Tue, 11 Apr 2023 03:03:06 +0000 Received: by mail-pl1-x631.google.com with SMTP id m18so6456372plx.5 for ; Mon, 10 Apr 2023 20:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681182184; x=1683774184; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=8ZyPCYyd/KJe7gHg4NKPst5xz4+NhFz48fhCG7YiVJ8=; b=QuSIe3J8OhLHQikI3wOhDDA/DZkuMNYF4MqHrg5cxvDFSdw9m25XT1v5UJR7RPS+Xq aop0VzIryvH6QK1/h24UVBBKgoT3BaYj0Lkam8pQITzdE+HDvjuLojAossbfSFnVbVs5 NeBTgSZgTcZJoqOJlA/P6gPK4YezG9Fbyb6fHzpOQMhiuhk4kLUJDktpWk4OWQgPe6V/ v0PAIRptMXL43PEfWorLnRj1WlwnSqjUZDWMHD2yX3Vofdjg/CatB2qNz4WZgpVDeQyg hsiwNem81Ax/quJC5Kq2wLdxE/5JyDnOh6TQlB8n4EQiXqmdAl9PzZ9L9UAlt91P1/Wp Ty7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681182184; x=1683774184; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8ZyPCYyd/KJe7gHg4NKPst5xz4+NhFz48fhCG7YiVJ8=; b=kNGloTLZrPuUIC8KbklZqJvzveaTKgGoAPphCEoftR+Ek9xVO+wHoQFAXIv5uirOSW qSfW9HennmjlSDzaZGGHZ4+vxnilp2OlPwvZJrlx81ddt3qHZER7htxW27BaSLrKdFpt /ppQNf7BGV8jk7hOQJ8qHyhBAHVwM9c4Nr/RrtVfSORmXZBbric0AAMrruy9yY/lxAvb qha6PGiqzStb5lLupEtEo+8E10mmIFQxCKZ1nR6GKuJLvfE+gzkGySkHv6Z2TbYWlCkn Zx7CzNK8cRCyEQB1qceg5oB9e7UXL7R80LBY5jnPziWZqaKrlj0aU5rpjJgVpu9ktD2A x5AA== X-Gm-Message-State: AAQBX9eSUcpLsgy9m5DVFC/ub95SC7PXFmpko1qYkTyvJP68TjZXXVA+ USjFjv4/hVek8bY0+F0GE2EiS87cMpc= X-Google-Smtp-Source: AKy350bCmCMdIDifIYa+FvJbieL49wRx+skwrzjEo6z2DY9S6AMQLKVtEufvSTPSDHekwIaJcvCsOw== X-Received: by 2002:a17:90b:4c8e:b0:231:24c1:8028 with SMTP id my14-20020a17090b4c8e00b0023124c18028mr2026953pjb.29.1681182183934; Mon, 10 Apr 2023 20:03:03 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id e9-20020a17090a118900b002310ed024adsm4941615pja.12.2023.04.10.20.03.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Apr 2023 20:03:03 -0700 (PDT) Date: Tue, 11 Apr 2023 12:03:01 +0900 (JST) Message-Id: <20230411.120301.93333867350615278.horikyota.ntt@gmail.com> To: andres@anarazel.de Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Support invalidating replication slots due to horizon and wal_le From: Kyotaro Horiguchi In-Reply-To: References: User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > Support invalidating replication slots due to horizon and wal_level This adds the following message. + appendStringInfo(&err_detail, _("Logical decoding on standby requires wal_level to be at least logical on the primary server")); This message is missing a period at the end. regards. diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c index 41848f0ac6..e73fd2d13b 100644 --- a/src/backend/replication/slot.c +++ b/src/backend/replication/slot.c @@ -1274,7 +1274,7 @@ ReportSlotInvalidation(ReplicationSlotInvalidationCause cause, break; case RS_INVAL_WAL_LEVEL: - appendStringInfo(&err_detail, _("Logical decoding on standby requires wal_level to be at least logical on the primary server")); + appendStringInfo(&err_detail, _("Logical decoding on standby requires wal_level to be at least logical on the primary server.")); break; case RS_INVAL_NONE: pg_unreachable(); -- Kyotaro Horiguchi NTT Open Source Software Center