Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm7Vj-0004w3-MW for pgsql-committers@arkaria.postgresql.org; Tue, 11 Apr 2023 06:29:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pm7Vi-0006qS-41 for pgsql-committers@arkaria.postgresql.org; Tue, 11 Apr 2023 06:29:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm7Vh-0006qJ-Pe for pgsql-committers@lists.postgresql.org; Tue, 11 Apr 2023 06:29:45 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pm7Vb-0000BS-QC for pgsql-committers@lists.postgresql.org; Tue, 11 Apr 2023 06:29:44 +0000 Received: by mail-pj1-x1033.google.com with SMTP id ie17-20020a17090b401100b00246d4b282eeso2102117pjb.2 for ; Mon, 10 Apr 2023 23:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681194578; x=1683786578; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=pZ8RAreqlkRMkdM3qv6t6DiaFy9zaQiUWEL4oLVBUNE=; b=mUyzNEvJ8afuN3WLxEhHBifNBw1iKGP5CYhDn+oUscB8qzJyt9jDSqvlB65UmXxJNR 1LGfEmBwi1EGWd9KtVw/FkB2UhEH/g/7JMn1n9iwydgrpmUfM2OGs5jODywTvx3vC45l KkzY/JiJyiytmyzhj7np7Kor28o0fstcv1Xn2vu6/2NGelfto94rQ1SdouGLz4DTM3v3 uSbekFSlfPNaIXsmMGvlQOXW/1qGhRQoo27Cak26Jo6vbxTzhuO1+G5mkJNK0pRoVa18 R2wTTV+7jPL9Kw9ED4eRPjvCUMdWG5y+7iUfY+Uqk1qQvCsJBCfUQXwTPnu+3CEqZn85 gevw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681194578; x=1683786578; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pZ8RAreqlkRMkdM3qv6t6DiaFy9zaQiUWEL4oLVBUNE=; b=xu7DE7BAvUH0mv7v3Ye/HD0HVeR2K4pC7tOWbGsAexItiNYGP4/HXdLYlkXvA6K+ND SUbGUUb9Pz+zm9laLwL6LV4CErUY6gJ82evqxI5Fws3rgPsbpf/FIfd3nltT6gvleMkE VOBQanjDavI+5mqXY+lP5lRMFLFzeZ2XYOrbZfkGBUd3BiJLG9cq9nzVEqS6PZy9smFO RYKjdTM/xfx6lcyvsC2uyU8TTVcsD+knsvkG0VHLfisO7Fo31r+vm0G+Y2RHOv6Yn6bj 27ab3dqJpzqnjE2Po5kX9a3WXntEGGjfaIr2ILkoj1Q4YmiemXCki1gnu9Twgjbs6wpS ASrg== X-Gm-Message-State: AAQBX9ceuqn21/iU3l3HcVzS6Y+cKSNOZzrzq4tHGsnyGNiJKKMe3Tx+ wPI1eAeu0t5aSFQc0MJYLeM= X-Google-Smtp-Source: AKy350b5wfdv0O6Oapw/FKXTdPR0psKRt48+tIVoEHBq/npB+MNOcK8Z1UMCv7LyIcMqQz7KHskOmA== X-Received: by 2002:a17:90b:1c07:b0:234:28ac:ec4a with SMTP id oc7-20020a17090b1c0700b0023428acec4amr16393821pjb.2.1681194578249; Mon, 10 Apr 2023 23:29:38 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id y5-20020a170902700500b001a1c2ee06e0sm8857216plk.15.2023.04.10.23.29.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Apr 2023 23:29:37 -0700 (PDT) Date: Tue, 11 Apr 2023 15:29:35 +0900 (JST) Message-Id: <20230411.152935.1833978170218450678.horikyota.ntt@gmail.com> To: dgrowleyml@gmail.com Cc: pgsql-committers@lists.postgresql.org, melanieplageman@gmail.com Subject: Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option From: Kyotaro Horiguchi In-Reply-To: References: <20230411.102335.1643720544536884844.horikyota.ntt@gmail.com> <20230411.120238.1102085277698061857.horikyota.ntt@gmail.com> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Tue, 11 Apr 2023 16:53:42 +1200, David Rowley wrote in > On Tue, 11 Apr 2023 at 15:02, Kyotaro Horiguchi wrote: > > > postgres=# vacuum (buffer_usage_limit); > > > ERROR: buffer_usage_limit requires a valid value > > > > The error message doesn't really make much sense to me. In the same > > context, most of the code seems to use ("%s requires a parameter", > > buffer_usage_limit) without "valid". > > The only other option I see that requires a value in this context is > "parallel", and what you say is not true for that, so I'm not sure I > follow what you're referring to with "most of the code". Can you quote > the code you mean? My point was just that "valid" seems redundant. (Sorry, but..) However, looking again, many of the "cases" are like "requires a value", which looks womewhat similar to "requires a valid value" when the cannot be represented by a word. Some remaining example of these "caes" are: ./commands/define.c54: errmsg("%s requires a parameter", (the "parameter" means the option value for type name) ./libpq/hba.c1319: errmsg("authentication method \"%s\" requires argument \"%s\" to be set", \ But, since I'm not a native speaker, so I don't stress this further more. > > vacuum.c:347 > > > errmsg("BUFFER_USAGE_LIMIT cannot be specified for VACUUM FULL"))); > > > > It seems like that the vacuum options are usually spelled in uppercase > > at least for vacuum and analyze. In any case, shouldn't we need to > > unify them in a certain area? (For example, command options for > > CREATE SUBSCRIPTION is shown in lowercase in the documentation. But, > > I'm not exactly sure what we should do about it.) > > I wouldn't object to making things more consistent in this area with > regards to the casing of the options in the ERROR messages. However, > it doesn't really seem like there is much consistency to follow that > this new code is breaking. ... > I do agree that it's not very good that I pushed the lowercase version > of buffer_usage_limit and the same in uppercase for the VACUUM FULL > conflict. I'll hold back from fixing that until we figure out the > other stuff. Thanks for the opinion! I agree to you. Thanks! -- Kyotaro Horiguchi NTT Open Source Software Center