Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmsBq-0006ZL-9g for pgsql-committers@arkaria.postgresql.org; Thu, 13 Apr 2023 08:20:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pmsBo-0002Gf-90 for pgsql-committers@arkaria.postgresql.org; Thu, 13 Apr 2023 08:20:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmsBo-0002GV-1p for pgsql-committers@lists.postgresql.org; Thu, 13 Apr 2023 08:20:20 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pmsBl-002bRu-HO for pgsql-committers@lists.postgresql.org; Thu, 13 Apr 2023 08:20:19 +0000 Received: by mail-pj1-x1033.google.com with SMTP id f2so5847405pjs.3 for ; Thu, 13 Apr 2023 01:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681374015; x=1683966015; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=sx9PA7pVsGwm0r3Y1qJM3c4dWtkWf02pwX9Tl12nQFI=; b=Hm10q7b8iw3jJAMJfm3wvqI+cejeVrLnnhZLEP97nk1eJz/+DDg8sGDa4YvnHOxnw6 u4e+aVkkpYKJ5UDsnbIrQr6Ams6kqRT4BfjWI+G8dy2TGytPf0Xf0fuuvmZY/RogxhZz S8nNnrJClTpmaFnKH/i8mfKR5YHu5bxqHtb4Cu+nHOJPUTZQtShmEMbYcp/6wWRL3F4z G2NrHJjCUVpKIwDqx1bO9m5FLfyPjtwWlxDE53IqCF9T77vLV0IKd/ETGMTN05RmAGlG RCevTvH1QO/3TgB3Hziva4nFS8ToSQ0DIG/sSioG5VhrhiZ7PEQ8myQ7EDff68IhAr1o ccZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681374015; x=1683966015; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sx9PA7pVsGwm0r3Y1qJM3c4dWtkWf02pwX9Tl12nQFI=; b=ZQBy2oK2c0IBFR7sZrpFPmUvfu64g8WUVUFBSnWTFfyDt6ISkF+OCAuq9B+z59x7bB C1ka5n5E+LNSt4p9Ju2SwcOyCb/FSiZMlwm39GP3o4yKqz+/PKm6sx1teY7GWeuxf8wO n4xVN6ThCLq81ys7H75lIrFMbQtVvTFF3cUtp2Tj+W7lgAsi21fsdKlw7HKejOP684OV PovZ1nQ1PP7lwXj3nL1QK91g8Ib+pGjOizgCLbzPenuceeIbhojw9e9Km/xOSpj/mKel vA6Bg+Pe8htt3UGrl1V0iKtrKo1Ak7XJqGDvzamKwI+28CGTrNGkG8vlNn8kjfJRMlnK zqPg== X-Gm-Message-State: AAQBX9dpVvUeWdh7BGhbdWIC3XtLECcHIDTrL+nKFwYR5qSguuZyptFZ Qz7nmMQlKrxiGnyKdyOIjiE= X-Google-Smtp-Source: AKy350Z4CehA5JVcyrzx+RUnZn++4knNEuiUZl0qZEF9hka46ouTzFogSYuxZnqvjYhexh6i8NT8Pw== X-Received: by 2002:a17:90a:9291:b0:23d:48a9:3400 with SMTP id n17-20020a17090a929100b0023d48a93400mr1159204pjo.31.1681374015172; Thu, 13 Apr 2023 01:20:15 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id w21-20020a1709029a9500b001a280c04528sm886738plp.248.2023.04.13.01.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 01:20:14 -0700 (PDT) Date: Thu, 13 Apr 2023 17:20:12 +0900 (JST) Message-Id: <20230413.172012.1496771207658465277.horikyota.ntt@gmail.com> To: andres@anarazel.de Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Allow logical decoding on standbys From: Kyotaro Horiguchi In-Reply-To: <20230412181000.sk67iouifwhnhhkh@awork3.anarazel.de> References: <20230411.120253.579856734111967616.horikyota.ntt@gmail.com> <20230412174244.6njadz4uoiez3l74@awork3.anarazel.de> <20230412181000.sk67iouifwhnhhkh@awork3.anarazel.de> User-Agent: Mew version 6.8 on Emacs 27.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Wed, 12 Apr 2023 11:10:00 -0700, Andres Freund wrote in > Hi, > > On 2023-04-12 10:42:44 -0700, Andres Freund wrote: > > On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote: > > > > Allow logical decoding on standbys > > > > > > This adds the following error message. > > > > > > + errmsg("logical decoding on a standby requires wal_level to be at least logical on the primary"))); > > > > > > We alredy have a nearly identical message as follows. > > > > > > > errmsg("logical decoding requires wal_level >= logical"))); > > > > > > And we used to writte this kind of conditions, like "wal_level >= > > > logical", using a mathematical operator. Don't we need to unify them? > > > > I guess. It doesn't seem particularly important, but why not. > > If we do that, we should adjust the errdetail() that you (correctly!) pointed > out as needing punctuation as well. Pushed those improvements together. Thanks! regards. -- Kyotaro Horiguchi NTT Open Source Software Center