Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnDzJ-0002F9-0o for pgsql-committers@arkaria.postgresql.org; Fri, 14 Apr 2023 07:36:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pnDzH-0000JJ-Kh for pgsql-committers@arkaria.postgresql.org; Fri, 14 Apr 2023 07:36:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnDzH-0000JA-DU for pgsql-committers@lists.postgresql.org; Fri, 14 Apr 2023 07:36:51 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pnDzA-002oEf-C1 for pgsql-committers@lists.postgresql.org; Fri, 14 Apr 2023 07:36:50 +0000 Received: by mail-pj1-x1031.google.com with SMTP id c10-20020a17090abf0a00b0023d1bbd9f9eso20888378pjs.0 for ; Fri, 14 Apr 2023 00:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681457802; x=1684049802; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=RdDvGtr3Iaz46bBtbqHyq04+AfnNFQRpXMbYRPfnvng=; b=F/haKGSAth0RYEZq3aMdQKeYQcUHfrlqDmOA4wCDHLvYc8pD0iV7HoTGpyHVh9OSOr elaV9Cm/eWExA3xmXj4afe6HnZmKIawpNfx/VcHfkuatmxcft7vVGymt0XVMraHndmW8 80MaSITciZoyqtiBLgFfWXylaU4ERi7aKJV2ueoWDH8J9s9CYaHTZSazK1vpzHxJHR5r ey8Fv9PSyi+f4UfbVzqGkp2nguJZK9NG5gRD/6+9QxAbnLt6K2QUXCiXli+IKvhm+hNf upDx/V6x3086XHgjcgbwjN2vXK9Mud51IQMegwCNdNChp1woweR6MvBNPhhvhKmljHaN kD2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681457802; x=1684049802; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RdDvGtr3Iaz46bBtbqHyq04+AfnNFQRpXMbYRPfnvng=; b=ZUFVZA1x+gDIiYKnty1yfZtqTDEQ0LhduciIIAB69MTwZujr5xQKZhHGLaRPujXBRA SIySc1bqJbIKchlGlRSSJqzqqE7mQM7m3rYkBPEUEaRjVszOyhe3G9Ruq8EBiodY5+w4 IHRm4O0KyHeAazL1MCVGaexbxrfhBywcx9wyTT2F/07MH2Si1CbeyO+WcJ+hBLEtOQHP gLDKv3HCtEVQlUICUYxhrITNqe8jMCRS8mWqlHl/R2/iSWPgkr2aqvHbhkePzjlYEXtJ EK08S21g++LKukhpnGNg/46ICTY3o/oklK47+i76aJbHrAtegtSA7b3C5vRyIb9db6Il 9row== X-Gm-Message-State: AAQBX9d02PqXalgTRLgEv/tnMcgW4SL+BLgfzvuJcPPAj4WbJGRpsUhN Z+Zda60wpUkWqAe8TrJ7kkVfYjyrHRE= X-Google-Smtp-Source: AKy350ZpIE13p9SPKCINC96k7wJIgEtFYWfVNY6OGp/NlS+gTelpzVPdOnP/I/PGv3aP/6Se6r6B4w== X-Received: by 2002:a17:902:eb89:b0:19c:d309:4612 with SMTP id q9-20020a170902eb8900b0019cd3094612mr1844622plg.6.1681457802158; Fri, 14 Apr 2023 00:36:42 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id jh7-20020a170903328700b001a1faed8707sm2549639plb.63.2023.04.14.00.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 00:36:41 -0700 (PDT) Date: Fri, 14 Apr 2023 16:36:39 +0900 (JST) Message-Id: <20230414.163639.1769329243014370943.horikyota.ntt@gmail.com> To: robertmhaas@gmail.com Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Allow logical decoding on standbys From: Kyotaro Horiguchi In-Reply-To: References: <20230411.120253.579856734111967616.horikyota.ntt@gmail.com> <20230412174244.6njadz4uoiez3l74@awork3.anarazel.de> User-Agent: Mew version 6.8 on Emacs 27.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Thu, 13 Apr 2023 12:07:19 -0400, Robert Haas wrote in > On Wed, Apr 12, 2023 at 1:43=E2=80=AFPM Andres Freund = > wrote: > > > And, a nearby commit addds the following message. > > > > > > + appendStringInfo(&err_detail, _("Logical decoding= > on standby requires wal_level to be at least logical on the primary server= > ")); > > > > > > This is omitting the indefinite article before "standby". I'm not sure > > > what to do about it but feel like we don't need it here. > > > > I don't think we need it either, but I'm not a native speaker. > > I am a native speaker of English and I think it is not required here. > If we were going to add an article, I think we would want an > indefinite one ("a standby") not a definite one ("the standby") > because we're talking about a general truism, not a situation that > pertains to one specific server. However, I don't think we should add > that because the current phrasing is more consistent with our general > practice. It's not the way you would actually talk, but it the way > that people often write error messages. For example, we say "file not > found" not "the file was not found," and nobody gets upset or confused > by that. Thaks for the clarification! regards. -- Kyotaro Horiguchi NTT Open Source Software Center