Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2ywl-0004xI-Fr for pgsql-hackers@arkaria.postgresql.org; Sat, 27 May 2023 18:47:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q2ywk-0004Rq-44 for pgsql-hackers@arkaria.postgresql.org; Sat, 27 May 2023 18:47:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2ywj-0004Rh-Qr for pgsql-hackers@lists.postgresql.org; Sat, 27 May 2023 18:47:21 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q2ywh-002DH9-8h for pgsql-hackers@lists.postgresql.org; Sat, 27 May 2023 18:47:20 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 51E805C00E0; Sat, 27 May 2023 14:47:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 27 May 2023 14:47:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1685213238; x=1685299638; bh=Qi aAbDwI9EPvkQSJWUidIhImBoFzGi3TzpEGuGisQZo=; b=PWDEatWop+LYahJcGB IbFTx67tHAJYZV/S2Zp+KZkwTIQat1j1rtjPV/V/yXcDSJT1qPBtrIqcFPaZYNwj jJJyMbvPwV+wtOqRQu4Vk27eKaNNSh2BTC8Pp8X1xXQswAKImU5rsWtUhZ6rsBGA PJXrxoSXks10c5qfs+3PvIKQz+1A8PohNg11t2/n9K6MHc0S6UP3Q3rY2rC2U9ZT 62mEIz7q188AWexNpEqjfLiHiUJ7nT6Zg3L+3G9zZZB5Vb3K0j4MxzDA4B3rJnDJ 8sC5Tasd4C+DfsSsHkOjx9XS88lZJAvtj5nQTdkrE3W7NUypqODHym6zrMk4aaKO x++g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1685213238; x=1685299638; bh=QiaAbDwI9EPvk QSJWUidIhImBoFzGi3TzpEGuGisQZo=; b=ewCDv92oX54ORb+WtLSRsgzT1OdFN Pvas9FdMj0llCoKrYNNWg80RAQfZLFneShEfgQcj3gvHvYLiKFo5zN/8UqKKH0Qx wWTVHEHsgvyQmii0cBSAQjFH5og2h12xrmC4VD7MOySkO9e76D8X51rXtqXk33IQ YOLcReuDxO6XBdEfcmhGOfaQTNBGPPTKElAKq8q4y4WOpIqrx0MSOhklhX30YLMB GNjzs9h9hAHLd1Ntp/G/bs08Sun4wHX9IJuSHT3txut+0hcZft/93jwcv1GR0km7 6NBXbI9qsYcQn8W/9dK3CVEDzJgvI7oVHl0z2xomB7QzWzU/j5NCJDIkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeekuddguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteev udeitedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 27 May 2023 14:47:17 -0400 (EDT) Date: Sat, 27 May 2023 11:47:13 -0700 From: Andres Freund To: Peter Eisentraut Cc: Tom Lane , Christoph Berg , PostgreSQL Hackers Subject: Re: testing dist tarballs Message-ID: <20230527184713.32pjrsfgm2pixwmu@alap3.anarazel.de> References: <933499.1684853190@sss.pgh.pa.us> <20230523184157.ao4ytkwqxkgp3glk@awork3.anarazel.de> <974623.1684867863@sss.pgh.pa.us> <20230524212437.jm6e3iiehtehivbh@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-05-26 09:02:33 +0200, Peter Eisentraut wrote: > On 24.05.23 23:24, Andres Freund wrote: > > First thing I noticed that 'make dist' doesn't work in a vpath, failing in a > > somewhat obscure way (likely because in a vpath build the the copy from the > > source dir doesn't include GNUMakefile). Do we expect it to work? > > I don't think so. Maybe we should just error out in that case, instead of failing in an obscure way down the line? > > Separately, it's somewhat confusing that we include errcodes.h etc in > > src/backend/utils, rather than its final location, in src/include/utils. It > > works, even without perl, because copying the file doesn't require perl, it's > > just generating it... > > The "copying" is actually a symlink, right? I don't think we want to ship > symlinks in the tarball? Fair point - still seems we should just create the files in the right directory instead of doing it in the wrong place and then creating symlinks to make them accessible... Greetings, Andres Freund