Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJMr3-0004As-Pe for pgsql-committers@arkaria.postgresql.org; Tue, 11 Jul 2023 23:33:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qJMr2-0000bz-J4 for pgsql-committers@arkaria.postgresql.org; Tue, 11 Jul 2023 23:33:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJMr2-0000bZ-C7 for pgsql-committers@lists.postgresql.org; Tue, 11 Jul 2023 23:33:12 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qJMqz-003Yqv-VN for pgsql-committers@lists.postgresql.org; Tue, 11 Jul 2023 23:33:11 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 26D3C5C0081; Tue, 11 Jul 2023 19:33:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 11 Jul 2023 19:33:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1689118389; x=1689204789; bh=DB ms/l039K+B38DNqyYJrin6kocPh3Brdw3KiEJmcBE=; b=RW3KlbB+js7PQhxULW p5YeR2CGPExYLzNqrMBJXX+x/g35+a6k8K3OSMeLNC6zeF1p7VA8j8wrupb+W+qh 4lY5/uv5Lx6yhbKOTBwNlR/12W1EopKoMY+XtQ7EAXvHX45ur15xLucaUwYfmFs+ Bh1fzXQXR+bcadwHLClbiMDlzTo0M5ZqAKD78Ht1e6xeYudDfXrLukrijDMmL1hE pUPv7HxcZrv5g3HJIiAqbY07TIHw4ZI6QBGiLyVZMgZvneT86k8DEPjMfNb1sFu8 TT8mmg7LMVLU0h18h/Tm863WHnvcXaxXUWxAS1FYz3AG34HWurjTqGVyZkETLthf d0ng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1689118389; x=1689204789; bh=DBms/l039K+B3 8DNqyYJrin6kocPh3Brdw3KiEJmcBE=; b=W96iLnFW/Nh6TpLKJfZIAtZCFJx8U O3HzMHNrXUxgLfTIuJqZqQb1uK2VUZk6Zm0xO9WR/KZbrZLM1lt2kc/REyLjd3IL oBth73EznqnI6v6619JHfaYKwotQWQznoMWObrUUAXxqdKiTu1tTlqaApv5KOMUw uybvCel2NXBXwxCnPQ2F5LrzFjz1fVNXjPI/sYyd5WqcR59UE0sQEPzPdKnkY4K9 heFs1GflFjDxcluKMoXJfnOM4Gn+yp++E8+iHbm7rU5hbqREON5qOgf+nDaGurl+ 40hTOjp+ZoJgVv55MCnzCm1Vd9gttq4kzO2tSl2roC6BT5G5UbNeHrIfQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrfedugddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesthdtre dttddtvdenucfhrhhomheptehnughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghn rghrrgiivghlrdguvgeqnecuggftrfgrthhtvghrnhepvdfffeevhfetveffgeeiteefhf dtvdffjeevhfeuteegleduheetveduieettddunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Jul 2023 19:33:08 -0400 (EDT) Date: Tue, 11 Jul 2023 16:33:07 -0700 From: Andres Freund To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Integrate pg_bsd_indent into our build/test infrastructure. Message-ID: <20230711233307.hu4wetabjm5f7ver@awork3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-02-12 17:22:27 +0000, Tom Lane wrote: > Integrate pg_bsd_indent into our build/test infrastructure. ... > src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl | 53 ++++++++++++++++++++++ I just saw a random failure of exactly one of the test in CI (when testing a new meson version, oddly enough): # Running: diff -upd C:/cirrus/src/tools/pg_bsd_indent/tests/elsecomment.0.stdout elsecomment.out [21:41:17.438](0.076s) not ok 13 - pg_bsd_indent output matches for elsecomment [21:41:17.438](0.000s) # Failed test 'pg_bsd_indent output matches for elsecomment' # at C:/cirrus/src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl line 50. And subsequently noticed that CI currently doesn't collect the tests.diff file, so I don't know why that failed. CI currently collects all *.diffs files, I don't really want it to also collect all .diff files, since most of the time that would be redundant with the .diffs file. Would you mind if I rename the output file to test.diffs? That seems to make more sense than explicitly capturing this file... Greetings, Andres Freund