Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJjFY-000556-A6 for pgsql-committers@arkaria.postgresql.org; Wed, 12 Jul 2023 23:28:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qJjFX-0006CE-5i for pgsql-committers@arkaria.postgresql.org; Wed, 12 Jul 2023 23:27:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJjFW-0006Bx-5O for pgsql-committers@lists.postgresql.org; Wed, 12 Jul 2023 23:27:58 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qJjFO-0006mr-S8 for pgsql-committers@lists.postgresql.org; Wed, 12 Jul 2023 23:27:57 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8D1CF5C00EB; Wed, 12 Jul 2023 19:27:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 12 Jul 2023 19:27:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1689204469; x=1689290869; bh=cZ GWvuOJZwVTrx4+dFACunPQjzajfgdW9WHhOhEtccI=; b=VTqSAknTN6DP2DPtyQ sHN/4zS7CjjDkbOgkZoReGmI+Y8sBxIbHHwjWZLfmd6d/Lz20MkbDWwnfKXn2dA4 lW96poCYD+2GBXYD1J3Vheq+refagdp8GyCTodwG++XiVATtQj5jwzKWjQwve5RQ CXIm+OiAj77y/nNC72GNlP733Mjlmj0qfev3wmsZxZYeX9TOkBzEo3HtOeQwOSHY zCdqeRPTMQZ7BEVtbdfEsSzbRTkqJXMN0QixuXYvccfqNk2SWUqegp0RthdB7kbt k02QtSvYtE0r7aSvZImb6H7B1VwN/uHjZdq+mdHvjYukX+h7tP7/Ry6gFVhEw6DU z2sQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1689204469; x=1689290869; bh=cZGWvuOJZwVTr x4+dFACunPQjzajfgdW9WHhOhEtccI=; b=a79eF/JEMLVt+xwBlARJsQNEVybu6 5rjZbd6GxYHfVxd2fLGk7ctezyIKIqX7JaP3GqL9rjz/DDLG0GWhVF1QgFzo3waK QKTGKXxMutYaB2WYCA4ANZZn6rHbMgBNV9MbeIiRseZoQOqI4TKynvXsoglhMjSN cg2fMv5kEC6vG63q+DR0k/Czc96e0n0F1+BaosuPit9ziFI17yIvEb1DJufJJa4c 9vlZaDzY+9BUQtkI6akUqjrxDPhWWy7qcWkXw59uvbz0PSqsanI1fVGMPgURDtnZ s8Yn7osVfNjdsouKJYu3LMDHmIT9tSX6lUo8cnNHeBS4DrTLLUd7CMYng== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrfeefgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesthdtre dttddtvdenucfhrhhomheptehnughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghn rghrrgiivghlrdguvgeqnecuggftrfgrthhtvghrnhepvdfffeevhfetveffgeeiteefhf dtvdffjeevhfeuteegleduheetveduieettddunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Jul 2023 19:27:49 -0400 (EDT) Date: Wed, 12 Jul 2023 16:27:48 -0700 From: Andres Freund To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Integrate pg_bsd_indent into our build/test infrastructure. Message-ID: <20230712232748.ty64ijqazim7ju7x@awork3.anarazel.de> References: <20230711233307.hu4wetabjm5f7ver@awork3.anarazel.de> <2602083.1689128498@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2602083.1689128498@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-07-11 22:21:38 -0400, Tom Lane wrote: > Andres Freund writes: > > And subsequently noticed that CI currently doesn't collect the tests.diff > > file, so I don't know why that failed. CI currently collects all *.diffs > > files, I don't really want it to also collect all .diff files, since most of > > the time that would be redundant with the .diffs file. > > > Would you mind if I rename the output file to test.diffs? That seems to make > > more sense than explicitly capturing this file... > > Sure Done. > I did not realize we had a standard for that. I guess we're developing one, just now :) Greetings, Andres Freund