Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZw7I-007oKf-KF for pgsql-committers@arkaria.postgresql.org; Sat, 26 Aug 2023 16:26:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qZw7H-00Axoq-8a for pgsql-committers@arkaria.postgresql.org; Sat, 26 Aug 2023 16:26:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZw7F-00Axo2-J4 for pgsql-committers@lists.postgresql.org; Sat, 26 Aug 2023 16:26:26 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qZw76-001BVH-Gr for pgsql-committers@lists.postgresql.org; Sat, 26 Aug 2023 16:26:24 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 71D0232002D8; Sat, 26 Aug 2023 12:26:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 26 Aug 2023 12:26:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1693067170; x= 1693153570; bh=t2o2x8LRzYIXaStE3RNZOO/b2WZHV+U9H8Jc0wHkDCg=; b=I pwB07k7EmqyH2GhlpWwa/WkiejeoXMfmZkXQwLMAw4stT2NU0B3ouuhW52uNnKMl hrOr562jqykBtembr8k45cHiuyVqQY2umP5CG05O/t/atxmgYoTPVVXBT5Hn/Zh6 JMAKK+r9NUYLEzynn4enGFgnpXyj9jheuUtZ3m39gwhJXArS8XdLaQukh/Vb6Iyu 5QLvcokfg1xr+KwxOvEqqzgqceJFxs6ndL6ZR/mnWYIgwnQd+zg5pG1nf9hK5rZ4 xORGGsQYxPc8YcMV81LxpMi/5ydHa5BRu4nygNdoIj8h6A0YuYTZM5cWPTBUnmUE o6u8I382ykASclgeTD/8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeftddguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhv rghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorh hgqeenucggtffrrghtthgvrhhnpedvkedtffduffdtffffheffhfejjefhgfeiueeukeej keffgfdufffhudffffeuveenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghl vhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Aug 2023 12:26:10 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 1763CA9; Sat, 26 Aug 2023 18:25:41 +0200 (CEST) Date: Sat, 26 Aug 2023 18:25:41 +0200 From: Alvaro Herrera To: Tom Lane Cc: Andrew Dunstan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Cache by-reference missing values in a long lived context Message-ID: <20230826162541.4cny4fb6z2cvpy4j@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4126204.1692970814@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-Aug-25, Tom Lane wrote: > Another point that I wasn't thinking of yesterday is that 11 is > still expected to compile on pre-C99 compilers. I'm not sure > to what extent we are still able to test that -- my old animals > have all gone to buildfarm heaven, although I see that Noah's > AIX menagerie is still soldiering on. Were we relying on "{ 0 }" > anywhere else pre-v12? We have a few occurrences of {0} in initializations in pg11, so it should work. $ git grep '{\s*0\s*}' -- *.c contrib/pgrowlocks/pgrowlocks.c: values[Atnum_xids] = "{0}"; contrib/pgrowlocks/pgrowlocks.c: values[Atnum_pids] = "{0}"; contrib/pgstattuple/pgstatapprox.c: output_type stat = {0}; contrib/pgstattuple/pgstattuple.c: pgstattuple_type stat = {0}; contrib/pgstattuple/pgstattuple.c: pgstattuple_type stat = {0}; src/backend/access/transam/xloginsert.c: XLogRecordBlockCompressHeader cbimg = {0}; src/backend/commands/explain.c: JitInstrumentation ji = {0}; src/backend/commands/explain.c: HashInstrumentation hinstrument = {0}; src/backend/commands/tablecmds.c: static Node bogus_marker = {0}; /* marks conflicting defaults */ src/backend/executor/execExpr.c: ExprEvalStep scratch = {0}; src/backend/executor/execExpr.c: ExprEvalStep scratch = {0}; src/backend/executor/execExpr.c: ExprEvalStep scratch = {0}; src/backend/executor/execExpr.c: ExprEvalStep scratch = {0}; src/backend/executor/execExpr.c: ExprEvalStep scratch = {0}; src/backend/executor/execExpr.c: ExprEvalStep scratch = {0}; src/backend/executor/execExpr.c: ExprEvalStep scratch2 = {0}; src/backend/executor/execExpr.c: ExprEvalStep scratch = {0}; src/backend/executor/execExpr.c: ExprEvalStep scratch = {0}; src/backend/regex/regcomp.c: /* postpone everything else pending possible {0} */ src/backend/regex/regcomp.c: /* annoying special case: {0} or {0,0} cancels everything */ src/backend/utils/adt/jsonfuncs.c: JsValue field = {0}; src/backend/utils/adt/jsonfuncs.c: JsValue jsv = {0}; src/backend/utils/adt/numeric.c:static const NumericDigit const_zero_data[1] = {0}; src/bin/pg_dump/pg_dump.c: "CASE WHEN pol.polroles = '{0}' THEN NULL ELSE " src/bin/psql/describe.c: " || CASE WHEN polroles <> '{0}' THEN\n" src/bin/psql/describe.c: " || CASE WHEN polroles <> '{0}' THEN\n" src/bin/psql/describe.c: " CASE WHEN pol.polroles = '{0}' THEN NULL ELSE pg_catalog.array_to_string(array(select rolname from pg_catalog.pg_roles where oid = any (pol.polroles) order by 1),',') END,\n" src/interfaces/ecpg/ecpglib/prepare.c:static stmtCacheEntry stmtCacheEntries[16384] = {{0, {0}, 0, 0, 0}}; -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/