Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qroc5-005te9-MB for pgsql-committers@arkaria.postgresql.org; Sun, 15 Oct 2023 00:04:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qroc3-009VTv-Cm for pgsql-committers@arkaria.postgresql.org; Sun, 15 Oct 2023 00:04:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qroc2-009VTn-V7 for pgsql-committers@lists.postgresql.org; Sun, 15 Oct 2023 00:04:07 +0000 Received: from mail-yw1-x112c.google.com ([2607:f8b0:4864:20::112c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qrobz-000W6i-2U for pgsql-committers@lists.postgresql.org; Sun, 15 Oct 2023 00:04:06 +0000 Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-5a7be88e9ccso41309077b3.2 for ; Sat, 14 Oct 2023 17:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; t=1697328241; x=1697933041; darn=lists.postgresql.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FGtXX+npjBrNCjkyclgo4WdcgVDjlwEth7YE+uBRCww=; b=IKpvvZCsiZqwtmkw+R14Dlk9lS41Z4GK1m+wGjIiHIezSP5iukCVUfArPCn2D5dUDA KdvYWJnEu9aXuJkL4aVDfXCRKfbSRdT66fLzlqHYpWs4gcQXPL5SYOaQS7gLfFL9Pt/T qtvutMuXuvO0M+UMLZZ/cyQ9zAMhsImaIZ7nA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697328241; x=1697933041; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FGtXX+npjBrNCjkyclgo4WdcgVDjlwEth7YE+uBRCww=; b=v9MeEkeXk0/gZ7rhufIZbOtQS7dRBYUqTAV1sP3anIe8MvPFulr5uNkBueAUPJcMdZ vy9qUbWwKZ7J9TUg1EpD9gwAedDQIaI3ncewvwwGanb+SCgPydBNc0dzZCh+7RaQN9FS FWIdsxoiJvTLVdmS2RowcB+sLQ2CMDiIBcuoZTzmcvYW4V76RmsMO9caj6iebDX4jU50 PZu4BTEzV9x1Ck7oiJCOMfdYb47Aoxe9eOhVVLOZuu04EI+elZofsc65K1BEhYbqSNjF PSZv8geoNXHvJxnOWqmUipu6UYT1Wih1TKgzYrNSEuOIefocSJCGmdD45PLW6VF48ldr gXew== X-Gm-Message-State: AOJu0YyJULit2XHY4M5ljt/Bwqjh0ShdNxrUNjRcW44MKZL2xpK76FD6 LnOgFf/sU1f4h0R8ophJEYC9hA== X-Google-Smtp-Source: AGHT+IHj9D19ba8vTre+Bx3eTwEGeEaVD0DRCOHVHiMpCjVCtoMiuHOUJB9ied8kZ/Y8I/7Lpd5Qrg== X-Received: by 2002:a81:6e88:0:b0:59b:ec10:915e with SMTP id j130-20020a816e88000000b0059bec10915emr31572508ywc.30.1697328241605; Sat, 14 Oct 2023 17:04:01 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::2e]) by smtp.gmail.com with ESMTPSA id u189-20020a0dd2c6000000b00585f60e970esm940144ywd.134.2023.10.14.17.04.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Oct 2023 17:04:01 -0700 (PDT) Date: Sat, 14 Oct 2023 17:03:58 -0700 From: Noah Misch To: Tom Lane Cc: Peter Geoghegan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic Message-ID: <20231015000358.2d@rfd.leadboat.com> References: <1974777.1697327121@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1974777.1697327121@sss.pgh.pa.us> User-Agent: Mutt/2.2.12 (2023-09-09) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Oct 14, 2023 at 07:45:21PM -0400, Tom Lane wrote: > Noah Misch writes: > > ... This fix makes interval_ops simply omit the support function, > > like numeric_ops does. Back-pack to v13, where btequalimage() first > > appeared. In back branches, for the benefit of old catalog content, > > btequalimage() code will return false for type "interval". Going > > forward, back-branch initdb will include the catalog change. > > Hmm, I'm not sure that that last is a good idea. The upshot of this > (because of the opr_sanity.out change) is that "make installcheck" > will fail against existing back-branch installations. That seems > more likely to cause problems/confusion than the alternative of just > depending on the code change. I'm way more worried about amcheck failing on all those indexes than I am about someone who needs to tweak their installcheck rig. I accepted the former as the least-bad option, but if any area needs more thought, I feel that's the area.