Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrq3L-005yi3-0o for pgsql-committers@arkaria.postgresql.org; Sun, 15 Oct 2023 01:36:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qrq3I-009kLf-3w for pgsql-committers@arkaria.postgresql.org; Sun, 15 Oct 2023 01:36:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrq3H-009kLX-Su for pgsql-committers@lists.postgresql.org; Sun, 15 Oct 2023 01:36:20 +0000 Received: from mail-yw1-x112d.google.com ([2607:f8b0:4864:20::112d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qrq3A-000igW-9J for pgsql-committers@lists.postgresql.org; Sun, 15 Oct 2023 01:36:19 +0000 Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-5a7c08b7744so40676537b3.3 for ; Sat, 14 Oct 2023 18:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; t=1697333771; x=1697938571; darn=lists.postgresql.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=M0R6anAtzPsymg0i4J2wCU3DBg+Qz+HvCUBcORNRZLg=; b=SCQlIXtVzks/eBIlp/S4gj1NhAlt1yy0C0FBdSmz681fHtL9oghEG0NUwK7H/04imc NWcNl4xlTvHTO7huo5GxKBcTEJpJXoeQ1CkvW438EKoD4nTWkV5Vo4bkj3sqW/LkaXRw 1t+VAatVzIMMAnzVk9qjzQzA+BlE8Nz+JhNo8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697333771; x=1697938571; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M0R6anAtzPsymg0i4J2wCU3DBg+Qz+HvCUBcORNRZLg=; b=roYP1cd4Masgf70qw03EFF9tBr5CEP9W83OggXAoddBMpc6m0lb+XPjcNH7m/D2wLf AuMLs1YYRDIyeFSxpYf2jkK8gJGGvtI2OhuJFEM5SeqkgxUBWeZSyplT7g4dbRNw23Pp pzoygf7aYxDBgDWOeO3wSknnHTa6xHXNXiimpOVzL4TyGqypZasZpRIL7eL0byBRQZk9 pNkAFc6rLXu9lBWGlWRGPCbId0dlkVNuEBp/DBabXPS8P0fso2Mv4pQdjfvqbPBCHn55 5fdw/tl3TEMz7fnq//rfXLAF4nJKbckH1eLDRBr/DcY6brlrkXESd7gg5R9oeA8rBd9L 95Eg== X-Gm-Message-State: AOJu0YyTMtEnXYADij0xYllG7HePqYlgViNP4/8kC96irKK3Hgdfg+qn SEVhL0KMswcC7w28D2bCh5fx3N70rMb+DGfmsHM= X-Google-Smtp-Source: AGHT+IEMEwvxBaBSPBx6C6pv3kpXfRBVkZMdkTWuuv3/kw16UnHVwwl3vQvqvwnwCpNk/uMErEm+8w== X-Received: by 2002:a0d:d486:0:b0:5a8:204c:5c9b with SMTP id w128-20020a0dd486000000b005a8204c5c9bmr5191406ywd.18.1697333770972; Sat, 14 Oct 2023 18:36:10 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::2e]) by smtp.gmail.com with ESMTPSA id q82-20020a815c55000000b00597e912e67esm990172ywb.131.2023.10.14.18.36.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Oct 2023 18:36:10 -0700 (PDT) Date: Sat, 14 Oct 2023 18:36:07 -0700 From: Noah Misch To: Tom Lane Cc: Peter Geoghegan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic Message-ID: <20231015013607.61@rfd.leadboat.com> References: <1974777.1697327121@sss.pgh.pa.us> <20231015000358.2d@rfd.leadboat.com> <1980111.1697329678@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1980111.1697329678@sss.pgh.pa.us> User-Agent: Mutt/2.2.12 (2023-09-09) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Oct 14, 2023 at 08:27:58PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Sat, Oct 14, 2023 at 07:45:21PM -0400, Tom Lane wrote: > >> Hmm, I'm not sure that that last is a good idea. The upshot of this > >> (because of the opr_sanity.out change) is that "make installcheck" > >> will fail against existing back-branch installations. That seems > >> more likely to cause problems/confusion than the alternative of just > >> depending on the code change. > > > I'm way more worried about amcheck failing on all those indexes than I am > > about someone who needs to tweak their installcheck rig. > > Well, that's indeed going to be a pain for affected people, but > it doesn't seem like a reason to also break installcheck. That's right. We don't have a standard that installcheck of v13.N will have zero diffs on an initdb from v13.0. Zero diffs would be help a tiny user population, and corrected catalog entries will help a different population. I don't think either choice does enough harm to reopen the decision. We've got bigger fish to fry.