Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qs9FX-006wy9-0T for pgsql-committers@arkaria.postgresql.org; Sun, 15 Oct 2023 22:06:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qs9FU-00DOh1-Qj for pgsql-committers@arkaria.postgresql.org; Sun, 15 Oct 2023 22:06:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qs9FU-00DOgt-Cx for pgsql-committers@lists.postgresql.org; Sun, 15 Oct 2023 22:06:13 +0000 Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qs9FM-000r6m-Ol for pgsql-committers@lists.postgresql.org; Sun, 15 Oct 2023 22:06:12 +0000 Received: by mail-yb1-xb34.google.com with SMTP id 3f1490d57ef6-d77ad095f13so3884766276.2 for ; Sun, 15 Oct 2023 15:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; t=1697407564; x=1698012364; darn=lists.postgresql.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MjiSi/mcQT1UofexrTAwKHN8o6k94IX/Si3kQ1psBIg=; b=D1yv4zOrwgES5FIifa9riTbdl79Mp8dJTNAMb0zJP0zTEFN60QVjtq8/y1JnakJU7w DvDK8M5vP45UZUs1VOT/dI16EN5lv5pYCgGbwvO+pxEj6USOglCmuaWtsYjqpFOQcUJn 3lAaH8OAfyfacLqgJxIskCeKuOuIfxOCcSRb4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697407564; x=1698012364; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MjiSi/mcQT1UofexrTAwKHN8o6k94IX/Si3kQ1psBIg=; b=Dtb8adD21HZX/bMfR5mDAMHy8rAHWZjAEDrVVZZbThnVNRSeC0QsX+R6tO3heru+sR 2CZoO93zCIC6hkBJnMm4r4qdYGMUhrMs/1M6x8FUBKgqmYoXSVbI9/6OMomsseclLizT HlixaR+VPOvV3V+2GqE+1FOLRiUWdUcOHDYABNDVG+BAvipv0OWYMjLHyOUfeN7ENaPE xJEuG02jVskwnK6cT8dOuHVxl2m0NoG/S25sUaEqIFnYcfoRUwKh2N4jtyiJuurWLxwe /Cq4NsxpyymdSwmR3c7iIBtr7uSVZVhXUzhhNtE1PqlOLaZt4G6tRRXjBnpjGWqtSUm1 7wMw== X-Gm-Message-State: AOJu0YwaEUkizUj72R0IfIvmtAaspaXfGxiQBpH4A4zSARRauV2EM9fQ ww+tC8w8G/L7oOudgpEq7EcM0/MiRkkheixlD+I= X-Google-Smtp-Source: AGHT+IF57aBd2RETY0wgtHg9FqtgJiKAvzf27n1/t0qXflTOVfpUC/F94XRz4a++ksDbQ+eUQVj0Pg== X-Received: by 2002:a25:6886:0:b0:d9a:ce53:4942 with SMTP id d128-20020a256886000000b00d9ace534942mr9874846ybc.0.1697407563749; Sun, 15 Oct 2023 15:06:03 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::2e]) by smtp.gmail.com with ESMTPSA id v15-20020a05690204cf00b00d0b0bbe574asm2140929ybs.44.2023.10.15.15.06.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Oct 2023 15:06:03 -0700 (PDT) Date: Sun, 15 Oct 2023 15:06:00 -0700 From: Noah Misch To: Tom Lane Cc: Peter Geoghegan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic Message-ID: <20231015220600.ed@rfd.leadboat.com> References: <1974777.1697327121@sss.pgh.pa.us> <20231015000358.2d@rfd.leadboat.com> <1980111.1697329678@sss.pgh.pa.us> <20231015013607.61@rfd.leadboat.com> <1991711.1697335375@sss.pgh.pa.us> <2124060.1697404378@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2124060.1697404378@sss.pgh.pa.us> User-Agent: Mutt/2.2.12 (2023-09-09) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sun, Oct 15, 2023 at 05:12:58PM -0400, Tom Lane wrote: > Peter Geoghegan writes: > > On Sat, Oct 14, 2023 at 7:02 PM Tom Lane wrote: > >> Noah Misch writes: > >>> That's right. We don't have a standard that installcheck of v13.N will have > >>> zero diffs on an initdb from v13.0. > > >> Um ... don't we? I do not recall very many cases where we changed > >> initial catalog contents at all in a point release, and I don't think > >> any of those cases intentionally created regression diffs. > > > This did come up in review. I deferred to Noah on the question. FWIW > > if I had authored this bugfix, it wouldn't have touched catalog > > contents on the backbranches. > > To research this, I looked at every post-dot-zero commit that touched > src/include/catalog, going back to the 7.4 branch (~ 2003). While > there are a lot that adjust internal C function declarations or the > like, there are darn few that touch the catalog data. Ignoring a few > that just adjusted pg_description entries, I found > > 283262cd9 et al > Fix bogus provolatile/proparallel markings on a few built-in functions > > aa7e04cb5 et al > Clean up some lack-of-STRICT issues in the core code, too > > 6e0a053a9 > Correct volatility markings of a few json functions > > cb651b624 et al > Fix incorrect pg_proc.proallargtypes entries for two built-in functions > > 0b11a1525 et al > Mark to_number() and the numeric-type variants of to_char() as stable, not > > aed597102 > anyarray really needs to be declared with typalign = 'd', so that entries > in pg_statistic are correctly aligned if they contain values that require > double alignment. Too bad we cannot force initdb for this in 7.4 branch. > > None of these commits had any side-effects on regression test cases, > and the log entry for cb651b624 explicitly notes that we didn't add > the same regression test case as in HEAD for fear that it'd fail with > older catalog contents. Commit e568e1e changed pg_rewrite and associated rules.out lines. It could have avoided the testing effect by modifying rules.sql to pass with or without the catalog mutation, e.g. by eliminating that output row with an additional qual on the query. Nobody brought that up in the six intervening years.