Feedback-ID: ia2694551:Fastmail
Date: Fri, 27 Oct 2023 12:47:44 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Alexander Korotkov <akorotkov@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Adjust parallel_schedule with event triggers on
 authenticated lo
Message-ID: <202310271047.mnwkql6nhbwi@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="b5bvsyfmxk2ttoz4"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <E1qwIIq-002YkM-PJ@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/202310271047.mnwkql6nhbwi%40alvherre.pgsql>
Precedence: bulk


--b5bvsyfmxk2ttoz4
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2023-Oct-27, Alexander Korotkov wrote:

> Adjust parallel_schedule with event triggers on authenticated login
> 
> Event triggers on authenticated login could catch the connection of the
> concurrent test.  In order to prevent this side effect we need to run
> the event_trigger test alone.

Hmm, not a fan, because the original lines of the event_trigger test,
which had no problem running in parallel, no longer do so.  Why not
split out only the new part of the test to run in non-parallel mode?
An effortless win of ~50 ms.

After this patch:

ok 211       + stats                                     644 ms
# parallel group (2 tests):  event_trigger oidjoins
ok 212       + oidjoins                                  103 ms
ok 213       + event_trigger                              57 ms
ok 214       - event_trigger_login                        16 ms
ok 215       - fast_default                               66 ms
ok 216       - tablespace                                156 ms
1..216
# All 216 tests passed.


Before:

ok 211       + stats                                     603 ms
ok 212       - event_trigger                              66 ms
ok 213       - oidjoins                                  113 ms
ok 214       - fast_default                               71 ms
ok 215       - tablespace                                161 ms
1..215
# All 215 tests passed.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

--b5bvsyfmxk2ttoz4
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment; filename="0001-paralelize-stuff.patch"