Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2hMa-000QcG-KZ for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Nov 2023 00:33:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r2hMY-003Obf-Cv for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Nov 2023 00:33:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2hMY-003ObM-3O for pgsql-hackers@lists.postgresql.org; Tue, 14 Nov 2023 00:33:06 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2hMR-005S3B-3q for pgsql-hackers@lists.postgresql.org; Tue, 14 Nov 2023 00:33:04 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 220B35C0225; Mon, 13 Nov 2023 19:32:58 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 13 Nov 2023 19:32:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1699921978; x=1700008378; bh=K7 hm+ju3VylQmpbX/bxE8EOLVx2qEEMVmMhrSD9XY6E=; b=v6EaOc3UyUICDv0ldJ X7efXv4LTO7ZqJViYIg4T5cBPOmnw8FWe6TtVKXqaKJE8xZ8wdsecg0j2LN152/F +Zp1hwOeHExJqRyUzIjzO/XHJyyX0wK5kE6vAubOhjMSa9MmH6wFSAjNzdijpbVw vP+LTgVkRFgjqAMXIZRLUpsMTOrZVODOkAkF3if/hnd7/QfK1XiliI698WV7XYGv NLJmlFqKDRTJIqeRYMPVEepQaqnNASkxJec3QxrYZszcE/3kNMS1l298LIym7MgU kgOyOwGAdJnYOiSyas8cmYighFKcSdRKM4twcf9eiSYUfnNorjb+noIcLr7yOzXZ rVYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1699921978; x=1700008378; bh=K7hm+ju3VylQm pbX/bxE8EOLVx2qEEMVmMhrSD9XY6E=; b=sc1i2aOS1bmgK69r9Ihg4iCb4ozVX iMX+CPyTrufBnwGEt0aJJZQGx6WZGVGcid7ezwtvLqd8qlabyeY+Q7ef73n7mhqH G53TVDHhQ1jNWl4GKisksWaH7lxglBuTipD0DWGNNA0BmWofNqDwcHOY5zoxEspr lRFZpPxRKEbQvScihQvIQDW+rwMm6HvI8a5XV8T04b8QcaFQyBCOHmE4Kj3DAKsg dYX/O7mR5Lhuuth8wzXDNSmIzlVymtWOUv16S7J3yeNMHXi1kLSP0zGcOu9Int9v LUBMORHCxzZd8dZqXqc18PaNTnIygaY4mbRVDx5apWohudEwgzRrmHURQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudefuddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepvdfffeevhfetveffgeeiteefhfdtvdffjeevhfeuteegleduheetvedu ieettddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Nov 2023 19:32:57 -0500 (EST) Date: Mon, 13 Nov 2023 16:32:56 -0800 From: Andres Freund To: Alvaro Herrera Cc: Bruce Momjian , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: doc: fix wording describing the checkpoint_flush_after GUC Message-ID: <20231114003256.huzptjmwb6c2prrb@awork3.anarazel.de> References: <202311131131.pmrvuac6ziy2@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202311131131.pmrvuac6ziy2@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-11-13 12:31:42 +0100, Alvaro Herrera wrote: > On 2023-Nov-09, Bruce Momjian wrote: > > > doc: fix wording describing the checkpoint_flush_after GUC > > Hmm. Is this new wording really more clear than the original wording? > I agree the original may not have been the most simple, but I don't > think it was wrong English. I think it was somewhat wrong (I probably wrote it) or at least awkwardly formulated. "force the OS that pages .. should be flushed" doesn't make a ton of sense. OTOH, the new formulation doesn't seem great either. The request(s) that we make to the OS are not guaranteed to be followed, so the "should be" was actually a correct part of the sentence. It probably should be something like: On Linux and POSIX platforms allows to request that the OS flushes pages written by the checkpoint to disk after a configurable number of bytes. Otherwise, these [...] > I'm not suggesting to revert this change, but rather I'd like to prevent > future changes of this type. Just saying it'd be sad to turn all the > Postgres documentation to using Basic English or whatever. +1 for the general notion. Greetings, Andres Freund