Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2zbh-001jB1-RH for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Nov 2023 20:01:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r2zbf-00AkNs-Hd for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Nov 2023 20:01:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2zbf-00AkJO-6m for pgsql-hackers@lists.postgresql.org; Tue, 14 Nov 2023 20:01:55 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2zbc-005aPF-0z for pgsql-hackers@lists.postgresql.org; Tue, 14 Nov 2023 20:01:53 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 679233200927; Tue, 14 Nov 2023 15:01:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 14 Nov 2023 15:01:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1699992109; x=1700078509; bh=Zf Jk/++kbLzjKInsgdqBAZar9I7l4KfcYP9npj89Kg8=; b=NVy7IV1MdkZ+94SeyR rPMdX//Zyn9fdsPBekco5CjekDnTr+OGBbElLn1ldEl1SKBNHIIBkFXjdUUGulwv YfXfyFAvMy/4wfOKenqUqvy4BdT6MI0cyUiG+TjuTNwgpRWcrYqfrRO2NbP3cxP8 X9EiwOx+VleAKM2VOh+E2Nd5FBLF22v+rHR4dLJuEtxhSs6QFnEmCtemiH/wq5OD XyErOCyXctoUClEa58RGcnH/sa7te/5j68TI8LRz252+PR33LyToiiy7C/fj05LA 8eJmbZ2eKMx2+Oz1isccp6AfrtPOMirgvTSg46C1osSbhyjUKRLvMAuKDxfsZBj3 0Fsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1699992109; x=1700078509; bh=ZfJk/++kbLzjK InsgdqBAZar9I7l4KfcYP9npj89Kg8=; b=w55C4HpJhxVxo1NgkkVz58HAhmOcW YUscxReFA+52uFfsbeANfjpM66a8uDk/YIr7qWZfX2bnRAsrOzk4wXPdN1Qbwe1X ds+BzZje2C+t9fgaSNt73du/gUZjPd+fV3o92n39OSvUTdxyoXpmItdtKzGBAYMW kgB6X2dOEngw1Soqm2Yf6ed5G+fYy8fgknV8bV2VtILxx0wKkvOMX2+ZSXcOrLuR szdcDWWrlbzwM6AxQIjjNcX5PB4IhDcCm84OWZFPLIPT5TdUaxWCGReXYzUKLvIm yBzFbTUbQa7Y6pXbtxc/1Qhfnybiv8f1tNkFxbSXbmGL3V0sC1YSBy3dw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeffedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhephfeigffgteeljeetjeehkeeiieffiefhhfdvgfdthfeugfdtiefgfedt vdehtdehnecuffhomhgrihhnpehpohhsthhgrhdrvghspdhsthgrtghkvgigtghhrghngh gvrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Nov 2023 15:01:48 -0500 (EST) Date: Tue, 14 Nov 2023 12:01:47 -0800 From: Andres Freund To: Alvaro Herrera Cc: Bruce Momjian , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: doc: fix wording describing the checkpoint_flush_after GUC Message-ID: <20231114200147.dwkb4uuzg76yuoav@awork3.anarazel.de> References: <20231114003256.huzptjmwb6c2prrb@awork3.anarazel.de> <202311141649.sjwd4c5kzzl6@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202311141649.sjwd4c5kzzl6@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-11-14 17:49:59 +0100, Alvaro Herrera wrote: > On 2023-Nov-13, Andres Freund wrote: > > On 2023-11-13 12:31:42 +0100, Alvaro Herrera wrote: > > > On 2023-Nov-09, Bruce Momjian wrote: > > > > > > > doc: fix wording describing the checkpoint_flush_after GUC > > > > > > Hmm. Is this new wording really more clear than the original wording? > > > I agree the original may not have been the most simple, but I don't > > > think it was wrong English. > > > > I think it was somewhat wrong (I probably wrote it) or at least awkwardly > > formulated. "force the OS that pages .. should be flushed" doesn't make a ton > > of sense. > > Heh, you know what? I was mistaken. There was indeed a grammatical > error being fixed. The complaint [1] was that "you" was missing in the > sentence, and apparently that's correct [2]. > [1] https://postgr.es/m/155208475619.1380.12815553062985622271@wrigleys.postgresql.org > [2] https://english.stackexchange.com/a/60285 Hm, I really can't get excited about this. To me the "you" sounds worse, but whatever... > > OTOH, the new formulation doesn't seem great either. The request(s) that we > > make to the OS are not guaranteed to be followed, so the "should be" was > > actually a correct part of the sentence. > > Hmm, I hadn't noticed that nuance. Your text looks OK to me, except > that "... after a configurable number of bytes" reads odd after what's > already in the sentence. I would rewrite it in a different form, maybe > > On Linux and POSIX platforms, checkpoint_flush_after specifies the > number of bytes written by a checkpoint after which the OS is requested > to flush pages to disk. Otherwise, these pages ... That works for me! Greetings, Andres Freund