Feedback-ID: id4a34324:Fastmail
Date: Fri, 1 Dec 2023 09:12:19 -0800
From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
Message-ID: <20231201171219.nwf6vuspsclmid4u@awork3.anarazel.de>
References: <E1r5Fwj-006RcU-Sh@gemulon.postgresql.org>
 <746ba786-85bb-d1f7-b613-57bec35c642a@dunslane.net>
 <20231129022843.6vfvgxjqpbgb62p5@awork3.anarazel.de>
 <703110e4-b495-e409-26a5-28e9fca8f3a5@dunslane.net>
 <ae3b453e-a6be-3b9f-a8fe-a885d5d2795c@dunslane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ae3b453e-a6be-3b9f-a8fe-a885d5d2795c@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/20231201171219.nwf6vuspsclmid4u%40awork3.anarazel.de>
Precedence: bulk

Hi,


On 2023-12-01 09:04:19 -0500, Andrew Dunstan wrote:
> On 2023-11-29 We 07:20, Andrew Dunstan wrote:
> > On 2023-11-28 Tu 21:28, Andres Freund wrote:
> > > On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote:
> > > > On 2023-11-20 Mo 20:53, Andres Freund wrote:
> > > > > meson: docs: Add {html,man} targets, rename install-doc-*
> > > > > 
> > > > > We have toplevel html, man targets in the autoconf build as
> > > > > well. It'd be odd
> > > > > to have an 'html' target but have the install target be
> > > > > 'install-doc-html',
> > > > > thus rename the install targets to match.
> > > > 
> > > > This commit of one of its nearby friends appears to have broken
> > > > crake's docs
> > > > build:
> > > > 
> > > > ERROR: Can't invoke target `html`: ambiguous name.Add target
> > > > type and/or path:
> > > > - ./doc/src/sgml/html:custom
> > > > - ./doc/src/sgml/html:alias
> > > > 
> > > > See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04>
> > > > 
> > > Ah, I realize now that this is from meson compile html, not 'ninja
> > > html'. That
> > > explains why I couldn't reproduce this initially and why CI didn't
> > > complain.
> > > I don't really understand why meson compile complains in this case. 
> > > I assume
> > > you don't want to disambiguate as suggested, by building html:alias
> > > instead?
> > > 
> > 
> > I've done that as a temporary fix to get crake out of the hole, but it's
> > pretty ugly, and I don't want to do it in a release if at all possible.
> 
> 
> and doing this has broken the docs build for release 16.

If I can get somebody to comment on
https://postgr.es/m/20231129183619.3hrnwaexbrpygbxg%40awork3.anarazel.de
we can remove the need for the :$buildtype suffix.

Greetings,

Andres Freund