Feedback-ID: id4a34324:Fastmail
Date: Fri, 1 Dec 2023 14:12:55 -0800
From: Andres Freund <andres@anarazel.de>
To: Tristan Partin <tristan@neon.tech>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
Message-ID: <20231201221255.d7meekaycfrncorl@awork3.anarazel.de>
References: <E1r5Fwj-006RcU-Sh@gemulon.postgresql.org>
 <746ba786-85bb-d1f7-b613-57bec35c642a@dunslane.net>
 <20231129022843.6vfvgxjqpbgb62p5@awork3.anarazel.de>
 <703110e4-b495-e409-26a5-28e9fca8f3a5@dunslane.net>
 <20231129183619.3hrnwaexbrpygbxg@awork3.anarazel.de>
 <CXDBYZZR3T3Q.3CQUPEYXLP4NL@neon.tech>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CXDBYZZR3T3Q.3CQUPEYXLP4NL@neon.tech>
Archived-At: 
 <https://www.postgresql.org/message-id/20231201221255.d7meekaycfrncorl%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-12-01 15:55:29 -0600, Tristan Partin wrote:
> Commits look fine to me, but I hate the new target names...

You shouldn't ever need to use them anywhere - that's what the alias is for...

Happy to go another route if you have a suggestion.


> >  +    for name, v in targets_info_byname.items():
> >  +        if len(targets_info_byname[name]) > 1:
> 
> My only comment is that you could reverse the logic and save yourself an
> indentation.
> 
> - if len(targets_info_byname[name]) > 1:
> + if len(targets_info_byname[name]) <= 1:
> +     continue
> 
> But whatever you want.

Makes sense.