Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIXPA-0005t0-7A for pgsql-hackers@arkaria.postgresql.org; Fri, 11 Feb 2022 15:00:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nIXP8-0005rM-1M for pgsql-hackers@arkaria.postgresql.org; Fri, 11 Feb 2022 15:00:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIXP7-0005rB-Nv for pgsql-hackers@lists.postgresql.org; Fri, 11 Feb 2022 15:00:09 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIXP2-0007sv-Qh for pgsql-hackers@lists.postgresql.org; Fri, 11 Feb 2022 15:00:09 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21BExt332023926; Fri, 11 Feb 2022 09:59:55 -0500 From: Tom Lane To: Christoph Berg cc: Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc In-reply-to: References: Comments: In-reply-to Christoph Berg message dated "Fri, 11 Feb 2022 10:48:11 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2023924.1644591595.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 11 Feb 2022 09:59:55 -0500 Message-ID: <2023925.1644591595@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Christoph Berg writes: > this test is failing at Debian package compile time: > Could not open /usr/share/postgresql/15/postgresql.conf.sample: No such = file or directory at t/003_check_guc.pl line 47. > So it's trying to read from /usr/share/postgresql which doesn't exist > yet at build time. > The relevant part of the test is this: > # Find the location of postgresql.conf.sample, based on the information > # provided by pg_config. > my $sample_file =3D > $node->config_data('--sharedir') . '/postgresql.conf.sample'; This seems like a pretty bad idea even if it weren't failing outright. We should be examining the version of the file that's in the source tree; the one in the installation tree might have version-skew problems, if you've not yet done "make install". regards, tom lane