Feedback-ID: id4a34324:Fastmail
Date: Mon, 25 Mar 2024 11:48:24 -0700
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Daniel Gustafsson <daniel@yesql.se>, vignesh C <vignesh21@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Clean up role created in new subscription test.
Message-ID: <20240325184824.uxbh6o7w4442o4nv@awork3.anarazel.de>
References: <202312011219.aikuwve3cbku@alvherre.pgsql>
 <57373BD5-C0D9-486D-9096-276FE91411D7@yesql.se>
 <CALDaNm1eHOMxq0GmZstftKW+W8xxRsG6Ww5u4ncEVq7ZD+NrVw@mail.gmail.com>
 <1ECB500B-F76F-4BBE-AE4D-91DDC5E59D7E@yesql.se>
 <a6d4b632-e8fd-43e0-91ab-643d1e990941@eisentraut.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a6d4b632-e8fd-43e0-91ab-643d1e990941@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/20240325184824.uxbh6o7w4442o4nv%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2024-01-19 15:40:21 +0100, Peter Eisentraut wrote:
> On 19.01.24 15:26, Daniel Gustafsson wrote:
> > > On 18 Jan 2024, at 01:57, vignesh C <vignesh21@gmail.com> wrote:
> > 
> > > There are a lot of failures in CFBot at [1] with:
> > 
> > > More details of the same are available at [2].
> > > Do we need to clean up the objects leftover for the reported issues in the test?
> > 
> > Not really, these should not need cleaning up, and it's quite odd that it only
> > happens on FreeBSD.  I need to investigate further so I'll mark this waiting on
> > author in the meantime
> 
> Most likely because only the FreeBSD job uses
> ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS.

I don't think it's that, but that the freebsd task tests the installcheck
equivalent in meson.  I haven't checked what your patch is doing, but perhaps
the issue is that it's seeing global objects concurrently created by another
test?

Greetings,

Andres Freund