Date: Mon, 25 Mar 2024 15:00:26 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	shveta malik <shveta.malik@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Amit Kapila <akapila@postgresql.org>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Track last_inactive_time in pg_replication_slots.
Message-ID: <20240325200026.GA2924132@nathanxps13>
References: <E1roiEh-005Z7e-88@gemulon.postgresql.org>
 <CA+Tgmob_Ta-t2ty8QrKHBGnNLrf4ZYcwhGHGFsuUoFrAEDw4sA@mail.gmail.com>
 <CAA4eK1Ld9bSm1gEYD2_B78tkjhSpfG+ON-iJ7E3NiH5RLYtPOQ@mail.gmail.com>
 <CA+TgmoaCA-aaBiszkMKOTn6C3BKkY4hNAdNOLUhfMXdQxyrh9g@mail.gmail.com>
 <CAA4eK1+KAZoLBaPqnr8e8icF30fBMX1QwOBjYfLCZKXF_WRGnw@mail.gmail.com>
 <ZgGVZiZnvqRTDodo@ip-10-97-1-34.eu-west-3.compute.internal>
 <CA+TgmoaY6RvsFM39B0QXr2pTpSm8p2NovRLkYizFJLLyRYWN0A@mail.gmail.com>
 <ZgGibamdXfvyqaZ5@ip-10-97-1-34.eu-west-3.compute.internal>
 <CA+TgmoZj8zDJUdEXr4BP5MQvpUkj82M7APeOUTRUQUS_cVdGHg@mail.gmail.com>
 <ZgGrCBQoktdLi1Ir@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZgGrCBQoktdLi1Ir@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: 
 <https://www.postgresql.org/message-id/20240325200026.GA2924132%40nathanxps13>
Precedence: bulk

On Mon, Mar 25, 2024 at 04:49:12PM +0000, Bertrand Drouvot wrote:
> On Mon, Mar 25, 2024 at 12:25:37PM -0400, Robert Haas wrote:
>> In the same vein, I think deactivated_at or inactive_since might be
>> good names to consider. I think they get at the same thing as
>> released_time, but they avoid introducing a completely new word
>> (release, as opposed to active/inactive).
> 
> Yeah, I'd vote for inactive_since then.

Having only skimmed some of the related discussions, I'm inclined to agree
that inactive_since provides the clearest description for the column.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com