Feedback-ID: id4a34324:Fastmail
Date: Sun, 7 Apr 2024 10:26:15 -0700
From: Andres Freund <andres@anarazel.de>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reduce branches in heapgetpage()'s per-tuple loop
Message-ID: <20240407172615.cocrsvboqm3ttqe4@awork3.anarazel.de>
References: <E1rtMxq-000wGZ-6c@gemulon.postgresql.org>
 <CAAKRu_ZXtWKCE-7XC5pJchUXRe9kQZmgX-NQjnc3BnO=nHRhrA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAAKRu_ZXtWKCE-7XC5pJchUXRe9kQZmgX-NQjnc3BnO=nHRhrA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20240407172615.cocrsvboqm3ttqe4%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2024-04-07 09:14:57 -0400, Melanie Plageman wrote:
> On Sun, Apr 7, 2024 at 3:29 AM Andres Freund <andres@anarazel.de> wrote:
> >
> > Reduce branches in heapgetpage()'s per-tuple loop
> >
> > Until now, heapgetpage()'s loop over all tuples performed some conditional
> > checks for each tuple, even though condition did not change across the loop.
> 
> I haven't reviewed exactly what this does, but heapgetpage() was
> removed (or split into two functions, rather) in 44086b097537, so I
> find the naming of this function, or, at least the comments, commit
> message and description a bit confusing.

Oops. That name was so ingrained in my head that despite looking over these
lines quite a few times, I couldn't spot that.

Will send an update to the thread.

Greetings,

Andres Freund