Date: Tue, 09 Apr 2024 10:46:13 +0900 (JST)
Message-Id: <20240409.104613.1653854506705708036.horikyota.ntt@gmail.com>
To: heikki.linnakangas@iki.fi
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: With gssencmode='require', check credential cache
 before connect
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <E1rtcH1-0012Sj-Hn@gemulon.postgresql.org>
References: <E1rtcH1-0012Sj-Hn@gemulon.postgresql.org>
User-Agent: Mew version 6.8 on Emacs 27.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20240409.104613.1653854506705708036.horikyota.ntt%40gmail.com>
Precedence: bulk

Hello.

At Sun, 07 Apr 2024 23:50:08 +0000, Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote in 
> With gssencmode='require', check credential cache before connecting

This commit adds the following error message (indentations are adjusted):

+	libpq_append_conn_error(conn,
+		"GSSAPI encryption required but it is not supported over a local socket)");

The closing parenthesis at the end of the message seems to be a
leftover from editing.

diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index 4bd523ec6e..e35bdc4036 100644
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -2927,7 +2927,7 @@ keep_going:						/* We will come back to here until there is
 						if (conn->raddr.addr.ss_family == AF_UNIX)
 						{
 							libpq_append_conn_error(conn,
-													"GSSAPI encryption required but it is not supported over a local socket)");
+													"GSSAPI encryption required but it is not supported over a local socket");
 							goto error_return;
 						}
 						if (conn->gcred == GSS_C_NO_CREDENTIAL)


About the following message:

+			libpq_append_conn_error(conn, "could not set ssl alpn extension: %s", err);

I'm not sure about the policy for writing acronyms in lowercase, but
other occurrences of ALPN (in backend code) seem to be written in
uppercase.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center