Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rxEGI-0079b4-H8 for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Apr 2024 23:00:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rxEGF-00FmuY-2a for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Apr 2024 23:00:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rxEGE-00Fmsn-2t for pgsql-hackers@lists.postgresql.org; Wed, 17 Apr 2024 23:00:14 +0000 Received: from fhigh3-smtp.messagingengine.com ([103.168.172.154]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rxEG6-001Wz3-84 for pgsql-hackers@lists.postgresql.org; Wed, 17 Apr 2024 23:00:13 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 7CFAD11400DF; Wed, 17 Apr 2024 19:00:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 17 Apr 2024 19:00:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1713394804; x=1713481204; bh=oSH5+r1MM4 35Q0xka5J0YJ5VuZboiqGTzuxlT5oqj/I=; b=eO+X3Wtu76NFs7vZsxN1mfG/oP MiUrob8XjMbIl4r003F9ltOrplTcG3dyQBxnbMB1uEbFhIDzK0jHJus6n4vLCdbS NR+KpJzIyp/UJhEObqa3RS2XcxCMWFFbtgsgAMHGoxeQVkUJvjoBqNT+vwnN860j lMcPafqQKrK50DalvIIXY2ywKWkOjDAZOFk+eBB3p/VzZvrBmWhoNImf57j4Fph4 6wjsToFU2HFtBSxKVGUr3vi6ZsN6694EQ8mWbCWNv7demFLs5o9ezRwv72Hv3eX8 tsVRO7EtLzJMeI+ryxaMUOUmy/Wfva6Tg5b6V/7JXPMnZ4Nt6GKgwlMi1jeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1713394804; x=1713481204; bh=oSH5+r1MM435Q0xka5J0YJ5VuZbo iqGTzuxlT5oqj/I=; b=ewehOjSlmjAUB/ne247IjOS7EXBYen9zWSIf88Opd+Ch fsbqaykepHML/NgYbFEXLGwmPzo/L0Y1jvIsJE4j2ABcO9zYCRieezKpd+4jQl4j FObEVzBu8+DmmlRbSPvP51uIQ+JKntJ+n3ybKfgr5jmSi/48YbNa2uJik4dEbFZ6 76pDN3MOVj5JEu+VETo7gFx4VuUDGlZVwgynATIsQhK/qR5TUAGu2PtU+BOAstFO ItT31S6P5smKToSG0jS5hC+noG2Byn7Kt2DswWMfTxavALWyenkUr2rSvCEBulP6 J8AK5Kx087lI6wmyuJ0lqWyBEpMoS6ttUiVs1sQdrw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejledgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpeetnhgurhgvshcuhfhrvghunhguuceorghnughrvghssegr nhgrrhgriigvlhdruggvqeenucggtffrrghtthgvrhhnpeevveeiffevjeetgfegfffgke euieeukedvtefhheeiudehjeelteejkeeitedtffenucffohhmrghinhepphhoshhtghhr vghsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Apr 2024 19:00:03 -0400 (EDT) Date: Wed, 17 Apr 2024 16:00:02 -0700 From: Andres Freund To: Christoph Berg Cc: pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: meson: Add initial version of meson based build system Message-ID: <20240417230002.mb2gv3hyetyn67gk@awork3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, Uh, huh. On 2024-04-17 15:42:28 +0200, Christoph Berg wrote: > Re: Andres Freund > > https://git.postgresql.org/pg/commitdiff/e6927270cd18d535b77cbe79c55c6584351524be > > This commit broke VPATH builds when the original source directory > contains symlinks. I.e. a symlink to the source directory, not a symlink inside the source directory. > Given there are no other changes I think this bit is at fault: > > > Modified Files > > -------------- > > configure.ac | 6 + > > +# Ensure that any meson build directories would reconfigure and see that > +# there's a conflicting in-tree build and can error out. > +if test "$vpath_build"="no"; then > + touch meson.build > +fi Argh, this is missing spaces around the '=', leading to the branch always being entered. What I don't understand is how that possibly could affect the prep_buildtree step, that happens earlier. Hm. Uh, I don't think it does? Afaict this failure is entirely unrelated to 'touch meson.build'? From what I can tell the problem is that config/prep_buildtree is invoked with the symlinked path, and that that doesn't seem to work: bash -x /home/andres/src/postgresql-via-symlink/config/prep_buildtree /home/andres/src/postgresql-via-symlink . ++ basename /home/andres/src/postgresql-via-symlink/config/prep_buildtree + me=prep_buildtree + help='Usage: prep_buildtree sourcetree [buildtree]' + test -z /home/andres/src/postgresql-via-symlink + test x/home/andres/src/postgresql-via-symlink = x--help + unset CDPATH ++ cd /home/andres/src/postgresql-via-symlink ++ pwd + sourcetree=/home/andres/src/postgresql-via-symlink ++ cd . ++ pwd + buildtree=/tmp/pgs ++ find /home/andres/src/postgresql-via-symlink -type d '(' '(' -name CVS -prune ')' -o '(' -name .git -prune ')' -o -print ')' ++ grep -v '/home/andres/src/postgresql-via-symlink/doc/src/sgml/\+' ++ find /home/andres/src/postgresql-via-symlink -name Makefile -print -o -name GNUmakefile -print ++ grep -v /home/andres/src/postgresql-via-symlink/doc/src/sgml/images/ + exit 0 Note that the find does not return anything. Greetings, Andres Freund