Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rxSRs-008rHZ-KF for pgsql-committers@arkaria.postgresql.org; Thu, 18 Apr 2024 14:09:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rxSRo-005LAy-Qf for pgsql-committers@arkaria.postgresql.org; Thu, 18 Apr 2024 14:09:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rxSRn-005LAp-Oh for pgsql-committers@lists.postgresql.org; Thu, 18 Apr 2024 14:09:08 +0000 Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rxSRh-003Sp9-Oj for pgsql-committers@lists.postgresql.org; Thu, 18 Apr 2024 14:09:05 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id B958B1140152 for ; Thu, 18 Apr 2024 10:09:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 18 Apr 2024 10:09:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1713449340; x=1713535740; bh=G YSj1QDElBZkieugOwADt4QYeB+EuPLw2X3CeR67xeE=; b=iJz1HUzJ7KFMqQ0cn KJ1tXdNoNGgMurgy19657l73ngvr/cNgsdZTAzQxi3PWUMy2Yf3Amq59tLAgzZQ4 S/AWDRT5P5qYZhtVnlRNz5vnkzy0rCqX/o/xgtZJ7oRqIG++MU6iJYqkw+sssEuj t1TbD/yY2CiuclFM6yzmgKnSHug9WsO1N5c4ea+867YLJCPqIP1LjmoVL7FjB9P1 Y9fX+iORNNaDYIf4bFysaK//s3GeJf0gGi9IwZM3KVD/UzOFpcItHHJOSvbZhFR+ Rf9QKHcS+Z4ryDkU4R5XmBUCRVUMWeGFUx2ALTYsltQ9viGGjx6QW0uw1edKPcGm 21ViQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudektddgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugfgjgesthekre dttddtjeenucfhrhhomheptehlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgv segrlhhvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepudejveejffejve duudetvdekieeuiedtvdeileefkeevjedufeeguedvjefhueelnecuffhomhgrihhnpegv nhhtvghrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 18 Apr 2024 10:09:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1713449338; bh=29zHD9waEFSfrVq1XN5vghKXL61xr5pkncZBLLO5dks=; h=Date:From:To:Subject:In-Reply-To:From; b=NgMumye5AkKa5TsuqWvX9PswPddDOmncfzq+zn9gvAE67U+LDfLmJhJA6glJtjJZZ Tz8ZrMslWlMeZKGqWKsf+Y3cUIZv29po3Kbr+9puLNQd4mutW4OFKm3QRUidVC3djP mLMerpU7xIdfbpWkxyzkrsnALyAYr0FMQwNqs/2fKJVLdp7Cds6/Aw1RKCG8/mcLVi 5La30/JY+IP2h12h/R3wr0DV/72xw3peXgrVvipGnt26tkvgGUOavdNl5ZoMzfhBXt xum/2ZCcAqOjVr28ok9eGzny75i/lTKsjgm68pFIqg2eVb/laZ5WqGIiJ7m8eRep8E MJOWwUAFleA4w== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id DB16F385; Thu, 18 Apr 2024 16:08:58 +0200 (CEST) Date: Thu, 18 Apr 2024 16:08:58 +0200 From: Alvaro Herrera To: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix restore of not-null constraints with inheritance Message-ID: <202404181408.kqlwnqwshxtr@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-Apr-18, Alvaro Herrera wrote: > Lastly, make two changes to pg_dump: 1) do not try to drop a not-null > constraint that's marked as inherited; this allows a dump to restore > with no errors if a table with a PK inherits from another which also has > a PK; 2) avoid giving inherited constraints throwaway names, for the > rare cases where such a constraint survives after the restore. Hmm, this last bit broke pg_upgrade on crake. I'll revert this part, meanwhile I'll be installing 9.2 to see if it can be fixed in a better way. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/