Date: Sun, 23 Jun 2024 18:03:11 -0700
From: Noah Misch <noah@leadboat.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Skip some permissions checks on Cygwin
Message-ID: <20240624010311.0b.nmisch@google.com>
References: <E1sHjJc-001KCN-H6@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1sHjJc-001KCN-H6@gemulon.postgresql.org>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20240624010311.0b.nmisch%40google.com>
Precedence: bulk

On Thu, Jun 13, 2024 at 12:12:29PM +0000, Andrew Dunstan wrote:
> Skip some permissions checks on Cygwin
> 
> These are checks that are already skipped on other Windows systems.

>  	skip "unix-style permissions not supported on Windows", 2
> -	  if ($windows_os);
> +	  if ($windows_os || $Config::Config{osname} eq 'cygwin');

> -	skip "group access not supported on Windows", 3 if ($windows_os);
> +	skip "group access not supported on Windows", 3
> +	  if ($windows_os || $Config::Config{osname} eq 'cygwin');

Cygwin does support Unix-style permissions, so I'm not following the rationale
for this change.  Can you say more?