Date: Sat, 2 Nov 2024 20:10:27 -0700
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move I/O before the index_update_stats() buffer lock
 region.
Message-ID: <20241103031027.09.nmisch@google.com>
References: <E1t7GgB-003cVa-Th@gemulon.postgresql.org>
 <2317336.1730601176@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2317336.1730601176@sss.pgh.pa.us>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20241103031027.09.nmisch%40google.com>
Precedence: bulk

On Sat, Nov 02, 2024 at 10:32:56PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > Move I/O before the index_update_stats() buffer lock region.
> 
> In branches before 17, this commit is causing some compilers
> to complain:
> 
> index.c: In function 'index_update_stats':
> index.c:2913:24: warning: 'relpages' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    if (rd_rel->relpages != (int32) relpages)
>        ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
> 
> I'm seeing that with RHEL8's gcc 8.5.0, and trawling the buildfarm
> shows at least 40 animals similarly unhappy.  (I noticed this because
> mamba, which is using -Werror, is actually failing.)

Hopefully now the code won't fool any compiler.