Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tWbJl-000Dj1-84 for pgsql-committers@arkaria.postgresql.org; Sat, 11 Jan 2025 13:14:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tWbJj-009GDI-Gr for pgsql-committers@arkaria.postgresql.org; Sat, 11 Jan 2025 13:14:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tWbJi-009GD9-Up for pgsql-committers@lists.postgresql.org; Sat, 11 Jan 2025 13:14:18 +0000 Received: from fout-b5-smtp.messagingengine.com ([202.12.124.148]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tWbJc-0014lw-2J for pgsql-committers@lists.postgresql.org; Sat, 11 Jan 2025 13:14:16 +0000 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.stl.internal (Postfix) with ESMTP id 9189E11400CE; Sat, 11 Jan 2025 08:14:10 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Sat, 11 Jan 2025 08:14:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1736601250; x=1736687650; bh=b bx73t6Fm3Mylb+qIN6Ln92ByNbQOV7qJPbqC9S9QDg=; b=kOHWavZF8ME0EGXgV M65+tPOhGVr3AGdFWW7Cexs6EIPE5WesdTBCj0r6qZGNgGRlTie5GWFCqAQtXM1j bCs/oklRledkF4cSktE5NG79q/gAK7jRLyQVnpFNOfWg8NTLF1KnBc6ilke1KkzJ 8TqglQD6dQDx+X8jEIG+dRzpqkEO/ikx+SxAt3wwIsCHNpJ9+752mwbt+1n05bKR pSK7J3DDK7yjDy7YdqBkBFuIHJf5A9fhdlxuCwUQP+Rgp6aRfD4Xyb2vxHnoOWH1 /bgID0Wuh40vwTDxHeokZbsT+MnfAEZK6gPXCxe8ovvjdjASpjm+d6lfDVNXl7uQ E/RUw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudehtddggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeen ucfhrhhomheptehlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhh drnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffh jeejhffgieeuueekjeekfffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrph hrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgpdhnsggprh gtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeiihhhjfihpkhhu sehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqtghomhhmihhtthgvrhhsse hlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrghdprhgtphhtthhopehjuggrvhhishes phhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Jan 2025 08:14:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1736601245; bh=61NmqPTE3/Ag8KkvjtGrZfY03YJHr0pRr917/iA0kR0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=QWZWZNG344LSZYgUaEQZKdQNSEC6Vlaq7SaxoMOYMwwdfTbkL8aV8VxQPq6UcNH2W CC+grWGl/XkeKL1uIoYNvDek1sTlaLqjQzfrIkzR7BOeBiOICUamo3ihRe6jhlrNJ2 GWNhHTkAzMspWheoci3qBiv9qf65DqytPBhWzM3j8dHAJ7nE26mKR0oW1grgsxvQyd N7AgS2AklzY60sEeRA1tjS71CLNenMcHYfvRDSjc+IyMMdrBV4xy80ihS7wDpgPIGj bUd0M+dZA4JaMck1yg18YIHZ9loHisyDCBc6T8Xedu6O8rT566XS2uGenHW+qgCebz IZNKPX5NXdTqg== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id E48B7307; Sat, 11 Jan 2025 14:14:05 +0100 (CET) Date: Sat, 11 Jan 2025 14:14:05 +0100 From: Alvaro Herrera To: Junwang Zhao Cc: Jeff Davis , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: TupleHashTable: store additional data along with tuple. Message-ID: <202501111314.vtwyf34ojkwp@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Jan-11, Junwang Zhao wrote: > Seems this introduced an indent issue? It should be a whitespace > rather than a tab after the semicolon. Yeah, there's an issue in execGrouping.c as well. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ Subversion to GIT: the shortest path to happiness I've ever heard of (Alexey Klyukin)