Feedback-ID: ia2694551:Fastmail
Date: Sat, 8 Mar 2025 10:56:55 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Alexander Korotkov <akorotkov@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org, Maxim Orlov <orlovmg@gmail.com>,
	Svetlana Derevyanko <s.derevyanko@postgrespro.ru>
Subject: Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs
Message-ID: <202503080956.vjxmabdkatan@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202503071820.j25zn3lo4hvn@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/202503080956.vjxmabdkatan%40alvherre.pgsql>
Precedence: bulk

On 2025-Mar-07, Álvaro Herrera wrote:

> I tested this, because of a refactoring suggestion [1] and I find that
> it's rather completely broken.

I think we need significantly more complex scheduling code if we want
this to actually work, possibly even having to hack the ParallelSlot
API some, so that we can inspect which tables have a running reindex and
know not to schedule the next one on it.  What we're doing now makes no
sense.

We should strike this out from the list of features of 17 and revert
this commit.

If we want this feature in 19, we need another go through the drawing
board.  (There's clearly not enough time to do it for 18.)

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/