Feedback-ID: ia2694551:Fastmail
Date: Mon, 10 Mar 2025 12:12:33 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Alexander Korotkov <akorotkov@postgresql.org>,
	pgsql-hackers@lists.postgresql.org, Maxim Orlov <orlovmg@gmail.com>,
	Svetlana Derevyanko <s.derevyanko@postgrespro.ru>
Subject: Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs
Message-ID: <202503101112.ozklxnrfw4dr@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAPpHfds0Y7pcOrhwuFSJXvs58-=tv=_odWMCoCch01P2QaXq1w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202503101112.ozklxnrfw4dr%40alvherre.pgsql>
Precedence: bulk

On 2025-Mar-09, Alexander Korotkov wrote:

> After second thought it's not so hard to fix.  The attached patch does
> it by putting REINDEX commands related to the same table into a single
> SQL statement.  Possibly, that could be better than revert given we
> need to handle compatibility.  What do you think?

Oh, this is an egg of Columbus solution, I like it.  It seems to work as
intended on a quick test.  Please add some commentary to run_reindex_command.

Maybe another, possibly better way to do this would be to use libpq
pipeline mode, sending all the commands for a table in one pipeline
instead of a single command.  The advantage of this would be that
server-side log entries for each command would be separate, and they
wouldn't appear clumped together in pg_stat_activity and so on.
However, this would require more invasive changes, so it might be better
to leave that for a future project -- it's certainly a harder sell for
such a change to be backpatched.  So I'm +1 on your current patch for 17
and master.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Puedes vivir sólo una vez, pero si lo haces bien, una vez es suficiente"