Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1trvcW-00Bolw-Sb for pgsql-committers@arkaria.postgresql.org; Tue, 11 Mar 2025 09:09:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1trvcV-00BjvV-Iw for pgsql-committers@arkaria.postgresql.org; Tue, 11 Mar 2025 09:09:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1trvcV-00BjvM-Aj for pgsql-committers@lists.postgresql.org; Tue, 11 Mar 2025 09:09:51 +0000 Received: from fout-b2-smtp.messagingengine.com ([202.12.124.145]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1trvcT-002CCW-20 for pgsql-committers@lists.postgresql.org; Tue, 11 Mar 2025 09:09:50 +0000 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfout.stl.internal (Postfix) with ESMTP id 312F911401F2; Tue, 11 Mar 2025 05:09:47 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Tue, 11 Mar 2025 05:09:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1741684187; x=1741770587; bh=i 0eKrWvFesUWhqnbU6tAAv5SItiu1lqjoOlh8pSVC9g=; b=a2sC5bUigQa3sh3rw 6VroKRL3AdzD0Dt62AdTg9ThxNHKwY2Qh234u3S+CvEJRBJ785NLY9feyxw8Cj0D otkYB8q+Ls++dCSfCPyPfdpZOlRl0hB7G+oFjadEQc/rvqKMltcvv7kPWgQR3UbK MjmToONBkqvu+Smm4HOs+e4L5JTg9795in5YCftf8Q0rMjQAijsfN43J7TJ3aUrS 4FuO+l57nlEs9ascOeN2GKVDwzhxn2dcohs+XuSYftDiHxKlsvh5e6F8lXlom4xd Pz2BITpK76IgMSB3zmWhjQXoq/42r8PEhOAKbwDU/dSsbf2u11QGRk7yMaHgYEnz 2Ratg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvddukeefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkgggtugfgjgesthekredttddt jeenucfhrhhomheplmhlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlh hvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepvdehueffhefgueekueef heehgffhuefgfedukeejveduffegffekgeffffevgeehnecuffhomhgrihhnpegvnhhtvg hrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgpdhnsg gprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehpvghtvghr segvihhsvghnthhrrghuthdrohhrghdprhgtphhtthhopehpghhsqhhlqdgtohhmmhhith htvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Mar 2025 05:09:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1741684184; bh=fIfNIu9aiFZ637xuTqa2tWhspGp+v0vHbKjsOHYwQyg=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=FGaCX1AERF8eY/ek8aD7iS69zdSTeLgux8JaTWo33k/3fI+Ct5WC0e3MXx/j+6KZz STeVoahIWwhHrw+81ioCl28N7CwVw23zgmzTVlTJU/kSVikAzcTWL5uuocrjLt4rcB TT3EIu0Gxi6h+17c8emXm+E6lCLEpweihWGFMJp0vlpx23Cz6X6/oTeCb4SvFhbzdo z8mT0/nhq4KkIogXDBh8WOvEyTsoCkex2DM+F30pV41J53rCyHhDx751k0LRPg1nJ4 P6hTDvtsJSVltmDDDgG0fBFNjnTejeU8lIJqWU4yqE18H4eZNtIfCkCaXNsKUgt6pv 738XQvuSwGbqA== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 752B591; Tue, 11 Mar 2025 10:09:44 +0100 (CET) Date: Tue, 11 Mar 2025 10:09:44 +0100 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Peter Eisentraut Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: refactor: re-add ATExecAlterChildConstr() Message-ID: <202503110909.qfctmbdypgom@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Mar-11, Peter Eisentraut wrote: > refactor: re-add ATExecAlterChildConstr() > > ATExecAlterChildConstr() was removed in commit 80d7f990496, but it is > needed in some subsequent patches for the NOT ENFORCED feature, to > recurse over child constraints. This adds it back in slightly altered > form. FWIW I disagree with this approach and I think this particular piece should not be committed until we have clarity on what is 0008 going to actually do. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "No tengo por qué estar de acuerdo con lo que pienso" (Carlos Caszeli)