Feedback-ID: ia2694551:Fastmail
Date: Wed, 12 Mar 2025 10:41:43 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Alexander Korotkov <akorotkov@postgresql.org>,
	pgsql-hackers@lists.postgresql.org, Maxim Orlov <orlovmg@gmail.com>,
	Svetlana Derevyanko <s.derevyanko@postgrespro.ru>
Subject: Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs
Message-ID: <202503120941.6zkwny2okkan@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAPpHfdsE4O15X=rbNt9f1KAyg2k6XcmHfUOrcWURKQ-yHPggAg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202503120941.6zkwny2okkan%40alvherre.pgsql>
Precedence: bulk

On 2025-Mar-11, Alexander Korotkov wrote:

> Thank you for your feedback!  I also think that pipelining would be a
> better options, but it's too invasive for backpatching. I've written
> comments for gen_reindex_command() and run_reindex_command().  I'm
> going to push this patch to master and 17 if no objections.

Looks good.

Actually, I don't understand why is run_reindex_command() calling
PQfinish().  Hmm, also, why is the 'async' parameter always given as
true?  Is that PQfinish() actually dead code?

[... Looks at git history ...]

Ah!  this is actually a problem older than your patch -- it appears that
the last (only?) caller with async=false was removed by commit
2cbc3c17a5c1.  I think it's worth removing that while you're at it.  We
no longer need executeMaintenanceCommand() in reindexdb.c anymore
either, I think.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/