Date: Mon, 31 Mar 2025 17:34:52 +0900 (JST)
Message-Id: <20250331.173452.1055787671997178480.horikyota.ntt@gmail.com>
To: johncnaylorls@gmail.com
Cc: john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org,
 cookt@blackduck.com
Subject: Re: pgsql: Inline CRC computation for small fixed-length input on
 x86
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: 
 <CANWCAZbA+sDBdSQFcyp_-1T-r5HKFMbLhjM0uwZWZNZ+T9R85A@mail.gmail.com>
References: <E1tz8dY-001tOE-31@gemulon.postgresql.org>
	<CANWCAZYRbrAyUG29SyVZdamEaSfX0FG=TuyhMaGyqJhpdTN=vg@mail.gmail.com>
	<CANWCAZbA+sDBdSQFcyp_-1T-r5HKFMbLhjM0uwZWZNZ+T9R85A@mail.gmail.com>
User-Agent: Mew version 6.8 on Emacs 27.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20250331.173452.1055787671997178480.horikyota.ntt%40gmail.com>
Precedence: bulk

At Mon, 31 Mar 2025 15:07:36 +0700, John Naylor <johncnaylorls@gmail.com> wrote in 
> Looking at the configure output, I don't see -msee4.2 (or equivalent),
> so it shouldn't be reporting that it's targeting SSE 4.2. Maybe it's
> using a cached value, and deleting the configure cache would clear
> this up? (CC'-d owner)

I'm not sure if it's related to this, but I got the following build error.

mm_crc32_u64' requires target feature 'crc32', but would be inlined into function 'pg_comp_crc32c_dispatch' that is compiled without support for 'crc32'
   70 |                         crc = _mm_crc32_u64(crc, *(const uint64 *) p);
      |                               ^
../../../../src/include/port/pg_crc32c.h:73:10: error: always_inline function '_mm_crc32_u32' requires target feature 'crc32', but would be inlined into function 'pg_comp_crc32c_dispatch' that is compiled without support for 'crc32'
   73 |                         crc = _mm_crc32_u32(crc, *(const uint32 *) p);
      |                               ^
../../../../src/include/port/pg_crc32c.h:75:10: error: always_inline function '_mm_crc32_u8' requires target feature 'crc32', but would be inlined into function 'pg_comp_crc32c_dispatch' that is compiled without support for 'crc32'
   75 |                         crc = _mm_crc32_u8(crc, *p++);
      |                               ^
3 errors generated.

> Rocky Linux release 9.5 (Blue Onyx)
> gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
> clang version 18.1.8 (RESF 18.1.8-3.el9)

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center