Date: Tue, 01 Apr 2025 09:48:24 +0900 (JST)
Message-Id: <20250401.094824.1077317221843812276.ishii@postgresql.org>
To: dgrowleyml@gmail.com
Cc: myon@debian.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add memory/disk usage for Window aggregate nodes in
 EXPLAIN.
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: 
 <CAApHDvoOHfFYXUryAymxiZjvyvhEt0ueeBOJRUOJWn1W7e3eyA@mail.gmail.com>
References: 
 <CAApHDvoZ4TeT2bSEaN+Nx94R0neBr1mmyDBx0Z5ZQXVUunu7JQ@mail.gmail.com>
	<Z-r9v0CUDyLeM-RB@msg.df7cb.de>
	<CAApHDvoOHfFYXUryAymxiZjvyvhEt0ueeBOJRUOJWn1W7e3eyA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20250401.094824.1077317221843812276.ishii%40postgresql.org>
Precedence: bulk

From: David Rowley <dgrowleyml@gmail.com>
Subject: Re: pgsql: Add memory/disk usage for Window aggregate nodes in EXPLAIN.
Date: Tue, 1 Apr 2025 11:09:11 +1300
Message-ID: <CAApHDvoOHfFYXUryAymxiZjvyvhEt0ueeBOJRUOJWn1W7e3eyA@mail.gmail.com>

> On Tue, 1 Apr 2025 at 09:40, Christoph Berg <myon@debian.org> wrote:
>> =# explain (analyze,buffers off,costs off) select sum(n) over() from generate_series(1,2048) a(n);
>>                                         QUERY PLAN
>> ──────────────────────────────────────────────────────────────────────────────────────────
>>  WindowAgg (actual time=2.073..2.686 rows=2048.00 loops=1)
>>    Window: w1 AS ()
>>    Storage: Disk  Maximum Storage: 65kB
> 
> Thank you for testing that. I've just pushed a patch to bump it up to 2500.
> 
> I suspect the buildfarm didn't catch this due to the tuplestore
> consuming enough memory in MEMORY_CONTEXT_CHECKING builds.

David,
Christoph,

Thank you for fixing this!
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp