Feedback-ID: ie3de48e3:Fastmail
Date: Mon, 14 Apr 2025 14:20:10 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Andrew Dunstan <andrew@dunslane.net>,
	Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Non text modes for pg_dumpall, correspondingly change
 pg_restore
Message-ID: <202504141220.343fmoxfsbj4@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="2h4sxwwjii2o4jzh"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <E1u0nMP-002gkh-0E@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/202504141220.343fmoxfsbj4%40alvherre.pgsql>
Precedence: bulk


--2h4sxwwjii2o4jzh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2025-Apr-04, Andrew Dunstan wrote:

> Non text modes for pg_dumpall, correspondingly change pg_restore

I think the new oid_string_list stuff in this commit is unnecessary, and
we can remove a bunch of lines by simplifying that to using
SimplePtrList, as the attached illustrates.  (Perhaps the names of
members of the proposed struct can be improved.)

I also propose to remove the open-coded implementation of pg_get_line.

WDYT?

I'm also not sure about the double sscanf() business there ... There
must be a better way to do this.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

--2h4sxwwjii2o4jzh
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-remove-unnecessary-oid_string-list-stuff.patch"