Feedback-ID: ie3de48e3:Fastmail
Date: Tue, 19 Aug 2025 12:31:14 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own
 file
Message-ID: <202508191031.5ipojyuaswzt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="27ajigsq7y4kupyx"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <476683.1755560289@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202508191031.5ipojyuaswzt%40alvherre.pgsql>
Precedence: bulk


--27ajigsq7y4kupyx
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2025-Aug-18, Tom Lane wrote:

> Michael Paquier <michael@paquier.xyz> writes:
> > On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote:
> >> Couldn't this have removed some #include-s from multixact.c?
> 
> > Right.  funcapi.h and fmgrprotos.h are direct dependencies, but
> > looking closer it is also possible to remove four more of them.
> 
> Sounds good!

Hmm, don't you find strange that dbcommands.h is still included there?
I wondered about that and found out that we have get_database_name()
declared there.  It sort-of makes sense, because it was originally done
by scanning pg_database, but since commit cb98e6fb8fd4 introduced a
syscache for it, we can have this routine in lsyscache.c/h instead,
where it feels more at home.  It also seems more sensible to declare
get_database_oid() in pg_database.h.  After these two changes, a lot of
files can stop including dbcommands.h.  This seems a nice cleanup to me,
and passes headerscheck.


-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/

--27ajigsq7y4kupyx
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-Avoid-including-commands-dbcommands.h-randomly.patch"