Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uoO63-0039w6-TE for pgsql-committers@arkaria.postgresql.org; Tue, 19 Aug 2025 15:18:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uoO62-00D9An-UV for pgsql-committers@arkaria.postgresql.org; Tue, 19 Aug 2025 15:17:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uoO62-00D9Af-Cc for pgsql-committers@lists.postgresql.org; Tue, 19 Aug 2025 15:17:59 +0000 Received: from fhigh-a1-smtp.messagingengine.com ([103.168.172.152]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uoO60-000jRj-1G for pgsql-committers@lists.postgresql.org; Tue, 19 Aug 2025 15:17:58 +0000 Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 46840140021C; Tue, 19 Aug 2025 11:17:55 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Tue, 19 Aug 2025 11:17:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm2; t=1755616675; x= 1755703075; bh=oOaw3i2oIqFvP0C0Ps35PVvUR+gx0FJBhrSg7xm3hYc=; b=r l3tEbTm7e20d5OtEypKRtFmlVokB6MMy9uPSFVtLB0o63qfqGQp8h6wQZMZG5ZLl vMlMiN3hwFLyrdNHi/Q6iW40baom4liKA7uaEmKgEln9LK2D8BCS3t/777egO95U shwZbTllBtkk8izRuJaiSlo2Rli2RQTdCVsDbnCoOWAAmYyjL8fxPksYS/hBRfLf iVJlrNRL+gPDVJnh4SdK6r+Dc4XdFE2bzChNzMTbl5Oqm0QNP1RlJxBfag8JBLlo vDBmg3wSh1jNMLyQPLILEYKfjZyaR5yg4WnXQBDWdhUOkVXwTf0BWFLoLb/37uxO e8FREPawVPD55jxkDtMTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1755616675; x=1755703075; bh=o Oaw3i2oIqFvP0C0Ps35PVvUR+gx0FJBhrSg7xm3hYc=; b=bNBUBk6shtKlr46dl s5dtCGvI9HIUBnaM1J1noWVhjQY9/gJ/AnmdACxqkuu65aojDx4OEymm76FaqkXi gP8OeBDMMfF0fP4NOE/uGOfACipOfp3xHQtZ/RnAC1SbsD8FIBb2hoRLFhH4LAnO ewiBONlp7fLVOEKas6PyQHnVgfvnFlW104JcGge7VckOugi0U09ukh9g5YLR6Yaj iDaMZu6mLh+/XoMQXmWfimZ9vEuETHBIEyogzNjC7KGNv9HQ4gB+xP/Cl85r/QPI EHsk6pDloS7HUHCdtMhSWzWNq5EgHJnGmgvcVe3CtlqUWkpei0GYj/dWlN8m5+zd shKBA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduheehkeefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheplmhlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtf frrghtthgvrhhnpeetuedvheffkeevgfeuheevteevkefggedttdeufeeuheduuddthfef fffhjeefffenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgv sehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtthhopeehpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopegrnhgurhgvshesrghnrghrrgiivghlrdguvgdprhgtphhtthho pegsvghrthhrrghnuggurhhouhhvohhtrdhpghesghhmrghilhdrtghomhdprhgtphhtth hopehpghhsqhhlqdgtohhmmhhithhtvghrsheslhhishhtshdrphhoshhtghhrvghsqhhl rdhorhhgpdhrtghpthhtohepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidprhgtph htthhopehtghhlsehsshhsrdhpghhhrdhprgdruhhs X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Aug 2025 11:17:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1755616672; bh=0vN/8/Y98eICv/nIfxPFqGibLLJrvReQXjWqHhJtZ2Y=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=z8rlWQmqjwEj1ZInVAS77QfelCCvLRNpGT0tUpDqR4Q3t1/yOvogCAq4i/KgTB7us JOiAZnYHkX1zlzimafW4J5qiweVSdTqWnkdJeXE+WBDViq8J7HIbPw25wisrM0FiK0 tSGHdZDd/3nueta0iSV8N50FggTTIkvaYdWh1ikPIiAnCUGYtx3dSqtX+8jhpVha7d USfbZ/iqA74jUqCTeBBwoklLv5Q0z0zTiH6IrN4xgAHZH9P2MhP/o2F8bfbgwTbwn9 cgsI4LzQWV+zRU1yuJsb6tWRdQ99QNwvA7+TR+OqyJqh3tTT2x+Sb0IunY5fCMAz9w jAg/sBL7U7lKA== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 68C6D90; Tue, 19 Aug 2025 17:17:52 +0200 (CEST) Date: Tue, 19 Aug 2025 17:17:52 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Andres Freund Cc: Bertrand Drouvot , Tom Lane , Michael Paquier , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file Message-ID: <202508191517.stvm64mnl5ss@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Aug-19, Andres Freund wrote: > On 2025-08-19 14:01:52 +0000, Bertrand Drouvot wrote: > > That said, autoconf does not report the issue, and that's because test/modules > > is missing in src/Makefile. Is there any reasons for that? If not, the attached > > fix it. > > That can't be the reason - it's reached from src/test/Makefile > > > SUBDIRS = perl postmaster regress isolation modules authentication recovery subscription Yeah, I'm not on board with making changes to the makefiles, because AFAIR the current arrangement is purposefully what is is. I did discover that my build script does "make install ; make -C contrib install", which means src/test/modules is not built. But that's a local fix for me. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ really, I see PHP as like a strange amalgamation of C, Perl, Shell inflex: you know that "amalgam" means "mixture with mercury", more or less, right? i.e., "deadly poison"